From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7313947A89B; Mon, 14 Sep 2026 14:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789397474; cv=none; b=e6UFeKiosQMI30CSR9fwd0OxjwNk57pd7ZIP4rZFjOevawiA9kNsrVyr+ErD8h0G9WxspEK9TQUYjJVTr8eE8f1RdK/AgpwdK/FVsdslKDd4f+KHg30BRh7VBOOGZNYALBjQjAYfbIY39z9hoUIz4uomnZIqY+uODce/zBX3xxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789397474; c=relaxed/simple; bh=4eY6nSFOq/Va/DPcpboYKZBk7jH8z6qFhz7/XnF2Xng=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=jMyBEHGGMLgMQn09TGXHmCLRZoyApuNbdd1aFGYOgG6K/MLzu96rWloKyLsAuTk7J1l+/ebZtpfZDIWi2wm9EHfKjhlTnap7yGNjCoB5VAj+m59rMxDzbOhfZEPXbTJoNhF3C8qM2COvwpSRVSGSCm4LY2iJ1C3Ke7x3kKNNU2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=mjlA8VU3; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="mjlA8VU3" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99FD91576; Mon, 14 Sep 2026 07:50:53 -0700 (PDT) Received: from [192.168.178.24] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 14DF33F86F; Mon, 14 Sep 2026 07:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1789397457; bh=4eY6nSFOq/Va/DPcpboYKZBk7jH8z6qFhz7/XnF2Xng=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=mjlA8VU3/wPr4fGHLHOy27VUoOJLDK1Md9hbXusyenIG6Msi/NrGc576r3T5+P3ND v3aAKee9OQwjnzEy+PLeuoA6Uj242BSoJDCG6X0rq92iZ1mhcCsy//bagStF39M71f Btik+Fsx1UPmE+fqdCbNXgGpBvJqqxxifhkIAvA4= Message-ID: <07d32b4c-1f00-45e5-b318-0f28bbb46f33@arm.com> Date: Mon, 14 Sep 2026 16:50:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 03/10] dt-bindings: arm: Add MPAM MSC binding From: Andre Przywara To: Yin Li , James Morse , Rob Herring , Shanker Donthineni , Ben Horgan , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Bjorn Andersson , Konrad Dybcio , Gavin Shan Cc: Drew Fustini , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Shaopeng Tan , trilok.soni@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, ganapatrao.kulkarni@oss.qualcomm.com, Srivathsa L Rao , Huang Yiwei , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org References: <20260914-mpam-resctrl-dt-knp-support-v2-0-bf6645bb2f65@oss.qualcomm.com> <20260914-mpam-resctrl-dt-knp-support-v2-3-bf6645bb2f65@oss.qualcomm.com> Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 9/14/26 16:41, Andre Przywara wrote: > Hi, > > On 9/14/26 11:37, Yin Li wrote: >> From: Rob Herring >> >> The binding is designed around the assumption that an MSC will be a >> sub-block of something else such as a memory controller, cache >> controller, >> or IOMMU. However, it's certainly possible a design does not have that >> association or has a mixture of both, so the binding illustrates how >> we can >> support that with RIS child nodes. >> >> A key part of MPAM is we need to know about all of the MSCs in the system >> before it can be enabled. This drives the need for the genericish >> 'arm,mpam-msc' compatible. Though we can't assume an MSC is accessible >> until a h/w specific driver potentially enables the h/w. >> >> Cc: James Morse >> Signed-off-by: Rob Herring >> Signed-off-by: James Morse >> Signed-off-by: Yin Li >> --- >>   .../devicetree/bindings/arm/arm,mpam-msc.yaml      | 199 +++++++++++ >> ++++++++++ >>   1 file changed, 199 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >> b/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >> new file mode 100644 >> index 000000000000..53a6fdbbf05f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/arm,mpam-msc.yaml >> @@ -0,0 +1,199 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/arm,mpam-msc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Arm Memory System Resource Partitioning and Monitoring (MPAM) >> + >> +description: | >> +  The Arm MPAM specification can be found here: >> + >> +  https://developer.arm.com/documentation/ddi0598/latest >> + >> +maintainers: >> +  - Rob Herring >> + >> +properties: >> +  compatible: >> +    items: >> +      - const: arm,mpam-msc                   # Further details are >> discoverable >> +      - const: arm,mpam-memory-controller-msc > > But that doesn't match the examples below, does it? Don't we want to > allow just "arm,mpam-msc", but also the memory controller string, with > "arm,mpam-msc" as a fallback? > I guess the pattern should then look similar to interrupt-names below? Just seeing that you fix this and other things up in patch 08/10 later. I think it's confusing to have this split now for a v2 still. I wouldn't be aware of previous review of this original patch, so it doesn't really matter. Please squash them. So I think you should merge 07/10 and 08/10 into their original patches, otherwise reviewers might just get confused. But you might wait for a bit with a repost, to see if there are more generic comments on DT support. Cheers, Andre