mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bernd Schubert <bernd.schubert@fastmail.fm>
To: qiwuchen55@gmail.com, miklos@szeredi.hu
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] fuse: Allow parallel DIO reads and check NOWAIT case for DIO writes
Date: Sun, 2 Feb 2020 22:25:43 +0100	[thread overview]
Message-ID: <07d333db-9ed3-2628-673e-cb614c31f29e@fastmail.fm> (raw)
In-Reply-To: <1580614487-1341-1-git-send-email-qiwuchen55@gmail.com>



> @@ -1518,6 +1525,9 @@ static ssize_t fuse_direct_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  
>  		res = __fuse_direct_read(&io, to, &iocb->ki_pos);
>  	}
> +	inode_unlock_shared(inode);
> +
> +	file_accessed(iocb->ki_filp);


Shouldn't the file_accessed() in different patch, with a description? It
looks totally unrelated to locking?


Thanks,
Bernd

  reply	other threads:[~2020-02-02 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02  3:34 qiwuchen55
2020-02-02 21:25 ` Bernd Schubert [this message]
2020-02-03  4:00   ` chenqiwu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07d333db-9ed3-2628-673e-cb614c31f29e@fastmail.fm \
    --to=bernd.schubert@fastmail.fm \
    --cc=chenqiwu@xiaomi.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=qiwuchen55@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®