From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219654E1C7E for ; Mon, 12 Oct 2026 20:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791836476; cv=none; b=Ca6ZrTbb3LpkyLf7EJi/BLZQsNTWSf8BEVQYhqR2IeWjsT3Pj139VHvSyxawWUb36oUUreSWNkL7FRCclIdiasxv5krAJk+7VM00cADObpT35s2IkIv5aofod3Jy4iOd2ToU2imZGPlgFLJ6keNL7nVNfTq6FMSqYuHylUqSzpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791836476; c=relaxed/simple; bh=7UIEB3A73ofI1JEPEVW7u76mIWqiduCC1j8GOZ2rTrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RTW9ZGCOgvtsTh4KdWHfiO3ZyoY565Tl0vasMaMm209w45Z/dePAL+ixRwKMpv2VpcG542M4quL6Xc4toHyl9YhFQQOGBYqFpdOgR3r2hcF7WA6Uim0OXoDX1ZlZa45aC8RZI8ajqrwqjhVBzyBWekuLxhQCcRUlnG3HadO401k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=Ge1m9jFg; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="Ge1m9jFg" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6d00d120b28so1449536eaf.1 for ; Mon, 12 Oct 2026 13:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1791836472; x=1792441272; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7YdOwQKvIOtKNWjhAuzTAXTxb0yaTLWKFCpvhJolByA=; b=Ge1m9jFgPccwqtKXKUzf/OW9C4i080feo3eBI5G1piO4dIiQlPKXOBBUT755ax1gLG 2rAk/BfSyoVo8xWiUu1wnjV6MQB4ykAhBn9bQu+X2AqAxrLemYRv+FoPbfSviQRNR7ip qEbWoBIb15TveaqSvYBMtNhG+ngUuE8RebMGyN5SE4ZzoIC09vjhs5ESts7cHlzW6zLN aXKlvHBCMTFdZZJSBxHXSMlP4FEGJuLdjixGHuF7r3QNTh5nsWJ4r8VuWvV5tBYG6CPp +t11drObYH8uC27P+QB2iYe9A6kVC7Sd+gCo45J1Edt6SozQ+oTDEOSyDzDxZZK/Gm/7 ohTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791836472; x=1792441272; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7YdOwQKvIOtKNWjhAuzTAXTxb0yaTLWKFCpvhJolByA=; b=2Bt1YCPYsEAXo4ahYwiXR2FAIcRrZ3dWyhWutHJqg313c5yNLKASRpoXeFZxF9Lx4b q5elXeG1M66fWdHIJMggdbA584oRjssgdXo2O8HFxYMZ4Sz2UGOe2jnesuFPOnMnZPjO PdyXhuJ+hC8FJQqTK3Qjzdelp+UHfbGXGkWDQdVQpPUfvVfeokSPTPzLTDHSy3FpfoPQ jzhc/9StQbnxguQH1KlGbA43XwxwPPbqUu/KqC7c91asARVEi+xu28gKf0yU2LHb0l5W JUnVMFPWNQAj+cjRa3jVQRAe2tdJSYSkS7mZjxsZXKtaD3tcVAkigoX4pAPUfjJ/KyJz qd3Q== X-Gm-Message-State: AFq9FYJ7SEMOUubUAcX6t/gI0VblsC7eypnAJfVY7aUH6MxIZ2+CSNGt mv4qSHSE4RG9dlLIp49KZaMc44iqcDUtRaK4NRuW5cayuc7VICntphi4wbPRLMwPMgQ= X-Gm-Gg: AYBFou2xpcWw3U28tZr5AGmSpyIJPnu06E5+6NnFwji72pzQjxczAnHrttAnQV3yQb2 u+OoH+xAzk/LxScMTHroSq1lItlhZzb3OG+3s62in5aoNNexT7xSDvsOSzKEJHHtSnGE0q1uTbN Rwotx5fH7PvmBhuDd7bikVPdMO2aQn2ejgQBgU0rCWKlC+3BxHq4jwO4u1fHzbvLlJ78NfECIKF R7uL/8gLRTJmJR82rifxKTMEHw9TcbkrEejSw+Uw4jYPnvUSrP7SocwCDtg1zAzxYA8SCudSjfZ Mgq1gfraBGhrlnm9EN9xKmvj/BNSbEVrigcVciAe2yhVJuRjdnruegmMu9PDrHnfPkZzdamU+Cx +AT2Am2GcsT6KwTV/T8QKxUEbB5OFaJ1/juPO0PZJM3Xa1MzcI2cdUpaYbCBz8IbuEJq8av6zTJ XhPE5Um4JJRsWNO4NdOzUWFiQlnEitObEZNEDfmMY5o+CQkbP0FNJR/CeyGIGhUoNJlzSLfF28T 6JQROx+K/tM0T5UwD0cd3DmB0k9PWLRf35WwyDc8b00vnKoKoS6jAsZHA== X-Received: by 2002:a05:6820:162a:b0:6f7:75ab:f969 with SMTP id 006d021491bc7-6f775bb41f5mr1943854eaf.66.1791836471882; Mon, 12 Oct 2026 13:21:11 -0700 (PDT) Received: from [192.168.1.106] ([198.8.77.135]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6ef02d91a5asm10237414eaf.14.2026.10.12.13.21.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 13:21:10 -0700 (PDT) Message-ID: <07d36bc7-637f-4554-9d6f-039e88852dc6@kernel.dk> Date: Mon, 12 Oct 2026 14:21:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 05/13] block: add dma-buf support for raw bdev To: Anuj Gupta/Anuj Gupta , Pavel Begunkov , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Nitesh Shetty , Kanchan Joshi , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/8/26 6:27 AM, Anuj Gupta/Anuj Gupta wrote: > On 10/7/2026 7:12 AM, Pavel Begunkov wrote: >> +static int blkdev_init_dma_buf_io_ctx(struct file *file, >> + struct dma_buf_io_ctx *ctx) >> +{ >> + struct block_device *bdev = file_bdev(file); >> + struct gendisk *disk = bdev->bd_disk; >> + >> + if (!(file->f_flags & O_DIRECT)) >> + return -EINVAL; >> + if (!disk->fops->init_dma_buf_io_ctx) >> + return -EOPNOTSUPP; > > dma-buf doesn't work with PI: bi_dmabuf_map aliases bi_io_vec, and > blk_integrity_iterate() walks it as bvecs to generate/verify the > checksum. rw-dmabuf liburing test hangs on a PI enabled NVMe. Something > like below is needed: > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index e929f94b25c7..1b7f8cbbda8b 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -3150,6 +3150,12 @@ void blk_mq_submit_bio(struct bio *bio) > goto queue_exit; > } > > + if (unlikely(op_is_dmabuf(bio->bi_opf) && > + bdev_has_integrity_csum(bio->bi_bdev))) { > + bio_endio_status(bio, BLK_STS_NOTSUPP); > + goto queue_exit; > + } > + > if ((bio->bi_opf & REQ_POLLED) && !blk_mq_can_poll(q)) { > bio_endio_status(bio, BLK_STS_NOTSUPP); > goto queue_exit; > diff --git a/block/fops.c b/block/fops.c > index e9da48ab73be..6c6700df943c 100644 > --- a/block/fops.c > +++ b/block/fops.c > @@ -976,6 +976,8 @@ static int blkdev_init_dma_buf_io_ctx(struct file *file, > return -EINVAL; > if (!disk->fops->init_dma_buf_io_ctx) > return -EOPNOTSUPP; > + if (bdev_has_integrity_csum(bdev)) > + return -EOPNOTSUPP; > return disk->fops->init_dma_buf_io_ctx(bdev, ctx); > } Can you send a separate patch? I've queued this series up for some testing. -- Jens Axboe