mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: "Herton R. Krzesinski" <herton@redhat.com>
Cc: Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>,
	akpm@linux-foundation.org, arnd@arndb.de,
	catalin.marinas@arm.com, malat@debian.org,
	joel@joelfernandes.org, gustavo@embeddedor.com,
	linux-kernel@vger.kernel.org, jay.vosburgh@canonical.com,
	ioanna.alifieraki@gmail.com
Subject: Re: [PATCH] Revert "ipc,sem: remove uneeded sem_undo_list lock usage in exit_sem()"
Date: Wed, 18 Dec 2019 20:25:03 +0100	[thread overview]
Message-ID: <07d574be-0d97-d0f8-8f22-017abebc6b6d@colorfullife.com> (raw)
In-Reply-To: <20191217211745.GT7463@unknown>

Hello together,

On 12/17/19 10:17 PM, Herton R. Krzesinski wrote:
> On Mon, Dec 16, 2019 at 08:04:53PM +0100, Manfred Spraul wrote:
>> Hi Ioanna,
>>
>> On 12/11/19 8:13 PM, Ioanna Alifieraki wrote:
>>
>>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1694779
>>>
>>> Fixes: a97955844807 ("ipc,sem: remove uneeded sem_undo_list lock usage in exit_sem()")
>>> Signed-off-by: Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
>> Acked-by: Manfred Spraul <manfred@colorfullife.com>
> Acked-by: Herton R. Krzesinski <herton@redhat.com>

What I forgot:

I think Cc: stable@vger.kernel.org should be added:

The change is obviously correct, it fixes a real issue.

>>> ---
>>>    ipc/sem.c | 6 ++----
>>>    1 file changed, 2 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/ipc/sem.c b/ipc/sem.c
>>> index ec97a7072413..fe12ea8dd2b3 100644
>>> --- a/ipc/sem.c
>>> +++ b/ipc/sem.c
>>> @@ -2368,11 +2368,9 @@ void exit_sem(struct task_struct *tsk)
>>>    		ipc_assert_locked_object(&sma->sem_perm);
>>>    		list_del(&un->list_id);
>>> -		/* we are the last process using this ulp, acquiring ulp->lock
>>> -		 * isn't required. Besides that, we are also protected against
>>> -		 * IPC_RMID as we hold sma->sem_perm lock now
>>> -		 */
>>> +		spin_lock(&ulp->lock);
>>>    		list_del_rcu(&un->list_proc);
>>> +		spin_unlock(&ulp->lock);
>>>    		/* perform adjustments registered in un */
>>>    		for (i = 0; i < sma->sem_nsems; i++) {
>>


  reply	other threads:[~2019-12-18 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 19:13 Ioanna Alifieraki
2019-12-16 19:04 ` Manfred Spraul
2019-12-17 21:17   ` Herton R. Krzesinski
2019-12-18 19:25     ` Manfred Spraul [this message]
     [not found]       ` <CAOLeGd3BY+pd7e2hnqAfwKZgfoEM22de1uhDdYC5H46DipgjDA@mail.gmail.com>
2020-02-14  3:30         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07d574be-0d97-d0f8-8f22-017abebc6b6d@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=gustavo@embeddedor.com \
    --cc=herton@redhat.com \
    --cc=ioanna-maria.alifieraki@canonical.com \
    --cc=ioanna.alifieraki@gmail.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®