From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934260AbcHaMxJ (ORCPT ); Wed, 31 Aug 2016 08:53:09 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:39049 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933974AbcHaMxH (ORCPT ); Wed, 31 Aug 2016 08:53:07 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-22-57c6d330cdce Subject: Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1472645613-5362-1-git-send-email-k.kozlowski@samsung.com> <1472645613-5362-2-git-send-email-k.kozlowski@samsung.com> <28320955.k33BrW2NEN@wuerfel> Cc: Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Tomasz Figa , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <07ddb8f8-a9e1-6105-ace9-edb5c8cc2f57@samsung.com> Date: Wed, 31 Aug 2016 14:53:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <28320955.k33BrW2NEN@wuerfel> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xK7oGl4+FGyx+y2nxd9IxdouNM9az Wsw/co7V4s3bNUwWr18YWvQ/fs1scf78BnaLTY+vsVpc3jWHzWLG+X1MFkuvX2SyaN17hN3i 8Jt2VotVu/4wOvB5rJm3htHj969JjB47Z91l99i0qpPNY/OSeo8t/UBe35ZVjB6fN8kFcERx 2aSk5mSWpRbp2yVwZRz8dpCloJ+74uiL1ywNjJ0cXYycHBICJhK7TvawQNhiEhfurWfrYuTi EBJYyijxeuYSZgjnGaPEnYNbmUGqhAV8JI60nWQDsUUE3CXWTZ/HClG0mFGi//lEsHZmga3M Erd+TWQHqWITMJbYvHwJG8QOOYne7klg+3gF7CROPL0HVsMioCrR2NwCFhcViJC4teojI0SN oMSPyffA4pwCWhKbnkwHmsMBtEBP4v5FLZAws4C8xOY1b5knMArOQtIxC6FqFpKqBYzMqxhF U0uTC4qT0nMN9YoTc4tL89L1kvNzNzFC4uvLDsbFx6wOMQpwMCrx8GbMOBouxJpYVlyZe4hR goNZSYRX7OKxcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFw SjUwlgf/FPu956/r6fhTx1N6fNV/nbDjntkdYsQmPFfx+L+QroUbjDNdJ+v9ZqkW/MFan1p9 eXpTTb3osZfipcaTv07vc9VLEAxRmC25a8E9v9WMlwrW3GndckpO/ni15ZFVyRXxD5SmrZu2 ZbvXvMQgCVnH9Wdv8nzNvf2XJ+o1d5re7AsfIyTTlViKMxINtZiLihMBmicR36sCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2016 02:42 PM, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 2:13:25 PM CEST Krzysztof Kozlowski wrote: >> >> +#define PIN_PULL_NONE 0 >> +#define PIN_PULL_DOWN 1 >> +#define PIN_PULL_UP 3 >> + >> +#define PIN_DRV_LV1 0 >> +#define PIN_DRV_LV2 2 >> +#define PIN_DRV_LV3 1 >> +#define PIN_DRV_LV4 3 >> + >> +#define PIN_FUNC_INPUT 0 >> +#define PIN_FUNC_OUTPUT 1 >> +#define PIN_FUNC_SPC_2 2 >> +#define PIN_FUNC_SPC_3 3 >> +#define PIN_FUNC_SPC_4 4 >> +#define PIN_FUNC_SPC_5 5 >> +#define PIN_FUNC_SPC_F 0xf > > Any reason for having a copy in each of those files instead of one > that is shared across all of them? The drive strengths differ between some of them. There are three groups of drive strengths: 1. Exynos3250, Exynos4 (all) and Exynos5250, 2. Exynos5260, 3. Exynos5410, 542x and 5800. Rest (functions and pull up/down) is the same so sharing the defines is possible but not that obvious. Solution would be for example adding a SoC-family prefix for PIN_DRV_LVx. Not that good... I could put it into three DTSI: - exynos3-pinctrl.dtsi (new file) - exynos5260-pinctrl.dtsi (like it is now) - exynos54xx-pinctrl.dtsi (new file) which would reduce the duplication. Other ideas? Best regards, Krzysztof