From: Joe Perches <joe@perches.com>
To: Michael Straube <michael.straube@posteo.de>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition
Date: Fri, 22 Jun 2018 18:59:06 -0700 [thread overview]
Message-ID: <07e414cea905277f1909d92dab47d3461ea91991.camel@perches.com> (raw)
In-Reply-To: <2c2a0f79-7970-8c55-6119-189114b279e3@posteo.de>
On Fri, 2018-06-22 at 21:11 +0200, Michael Straube wrote:
> On 06/22/18 19:28, Joe Perches wrote:
> > Although the last memcpy of a fixed mac address could
> > probably use eth_random_addr to reduce the likelihood
> > of mac address collision so maybe
> > eth_random_addr(mac_addr);
> Using a random address would be preffered?
mac address duplication is bad, so if there
were 2 instances of this device on the same
ethernet network, yes.
>
> Thanks for your help and patience.
> Michael
next prev parent reply other threads:[~2018-06-23 1:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:22 Michael Straube
2018-06-22 10:40 ` Dan Carpenter
2018-06-22 10:54 ` Joe Perches
2018-06-22 10:57 ` Dan Carpenter
2018-06-22 12:48 ` Michael Straube
2018-06-22 17:28 ` Joe Perches
2018-06-22 19:11 ` Michael Straube
2018-06-23 1:59 ` Joe Perches [this message]
2018-06-25 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e414cea905277f1909d92dab47d3461ea91991.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.straube@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®