From: Milan Broz <gmazyland@gmail.com>
To: Itai Handler <itai.handler@gmail.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
dm-devel@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Ondrej Kozina <okozina@redhat.com>
Subject: Re: [PATCH v2 0/1] dm-crypt: allow encryption sector size up to PAGE_SIZE
Date: Tue, 22 Sep 2026 15:07:22 +0200 [thread overview]
Message-ID: <07e750dc-570b-4f69-9ec3-68de51416a06@gmail.com> (raw)
In-Reply-To: <20260922120330.127262-1-itai.handler@gmail.com>
On 9/22/26 2:03 PM, Itai Handler wrote:
...> Exercised on arm64 with a 64K page granule: plain dm-crypt with
> sector_size 65536 over NVMe, block level round trip, fio random
Could you please point me to at least one consumer-grade NVMe drive that
supports a 64k sector size?
Allowing a bigger sector size in dm-crypt means you can end up with
partial dm-crypt sector writes (after power fail), which opens another
can of worms.
Your dm-verity argument does not apply here; it is a read-only target.
Also, arguments based on cryptsetup/LUKS2 do not make much sense for
kernel code. They must be compatible and work together, but dm-crypt
can be used without any userspace validation, so all limits must be
checked in the kernel.
LUKS2 limits the sector size to 4k for multiplatform compatibility.
dm-crypt itself can support bigger sectors, but I just do not see much
use for it with common NVMe drives or other storage.
Milan
next prev parent reply other threads:[~2026-09-22 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 12:03 Itai Handler
2026-09-22 12:03 ` [PATCH v2 1/1] " Itai Handler
2026-09-22 12:34 ` [PATCH v2 0/1] " Itai Handler
2026-09-22 13:07 ` Milan Broz [this message]
2026-09-22 13:49 ` Itai Handler
2026-09-22 21:34 ` Eric Biggers
2026-09-23 7:29 ` Itai Handler
2026-09-23 9:58 ` Mikulas Patocka
2026-09-23 11:39 ` Itai Handler
2026-09-23 11:59 ` Mikulas Patocka
2026-09-23 12:43 ` Itai Handler
2026-09-23 15:28 ` David Laight
2026-09-23 15:42 ` Itai Handler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e750dc-570b-4f69-9ec3-68de51416a06@gmail.com \
--to=gmazyland@gmail.com \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=itai.handler@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=okozina@redhat.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®