From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9804B37D111 for ; Fri, 27 Feb 2026 20:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223734; cv=none; b=mDaNPrCJ39dWgkt8g1OWRKykYLljZR5BKxKYzTezUvVB2aQ10Z40t2Rb44jTdudQJRMDxuEtckrnyiZ4KoKkXZ7JFJ2OVzZMZiAvl5CgliAnduei5GqglWWZajO/BW1zZW2izSHt7bIB01IzVaf3iWvbSyO67DExUXUR3xzBSC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772223734; c=relaxed/simple; bh=l7k69CtN+IiNcGJIP+6XPRW27ZmEutG6RFmbRhsiAKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BAcBGfL/vWVTIsPg5M/QBJbQZpjat1mkoo4hrN6DJUnRWeqfvdUT+NT4fmNMcNEWKORHnrPooUlE6nCZVQV2fbo2i72i1AFN5LwW1zdQJSpiSn5bLfwNmZ4mNwpU/LLbkO1zFfxDfNiCB3SlEZc6Kn6riC5AJk+9/x3VFK2+vfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YtzlMxOj; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YtzlMxOj" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so26490425e9.1 for ; Fri, 27 Feb 2026 12:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772223731; x=1772828531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=R5yXGsU6hwsugdRjdYVC6VN7lOu0FrSG1G+gKSiGlY4=; b=YtzlMxOjQo9ChHv2R5Mjp67/MSiDYpDT9aG5obJ8HdX16BK24GsLJ8/efa0VQ9rpUQ YM9RAPIn4B1M01Dceqr+DnNFd7enWAC8jq95KxlNADLqt9OKq8RiqCa7JLyzKhDwcMjH D5WgpIdfYOtCJiLMKVMopN7FTLk6g9bW2yb+Kz9wtboOJ1YS6wrMFUbPoms8Tc2ztHOz Cogf8WGfr9i/PTqEQXNnZ+kyIvJ9BJyqlhnJxgMuhDN4LkJoUIrPAilyfOtIbM208a7m WqEp2i6yezMkl7UE46bkGp5XwDHTjxZFe5UD2pJEdsC6EOae0zNOSYUa/oF3ofizhLD6 L6Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772223731; x=1772828531; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R5yXGsU6hwsugdRjdYVC6VN7lOu0FrSG1G+gKSiGlY4=; b=WdrXGp1gkaiZSa7q4DGKU4SB0D/UgQfMbXutD1/6PErnQk5YspXSfTHZIk/kGXfLYG MJDYtlouj3MQT0ui91Tm2XMWX4LzkZe5uBXEP1jn9mBP4HTKKSuBfZ4FpkMYKuATXNIE 46vw9PeEvNIaodaI9gdN6CMZMF2QaYIc27emijBrTUqOG+vKHphWmKgwaMyHZ4rUktCb 4O48616dnOc6pf3PB/hA+NmPRhUSM4ok5QyLZYEdA3+3hhjl3hxS3yviMtsCdelKO8Zp flrG9gWeuKOlR5n9QbDtYstipS+bTH//GKCTKfqUf1faE2H8Z4Qi6kadUW44R+kB5YQA TFcw== X-Forwarded-Encrypted: i=1; AJvYcCWbNwwgXmbTRHOV8JrBGOPAsPvJTF0O0LrHu/J3+Pg0WVvhYHUECyXinGgk570W3jCsVXu3bIQLZX633ZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6mvLG9EjHge8x6r1nYDOrtCLsiJamEGh85f8Dhm3grD/A0yIV wi24e6UXroz12T8maps5EJTHob57n0o5RoOT7+JvFEVslo2PtwCIx1CE4Xb8P9/cnZA4fyYt4vt ImZRQOtA= X-Gm-Gg: ATEYQzzjrLizbB6nMcSqG1CSVY2dNPh8XSzZdeI2BtnvW7DFA6s/XibKk8WEq2nunGE G5cODOfvmy0KzgsYsPfsPbPl9SypU5yc0eqgHlarCF9F176Us9IQy4Xvm25xbScpFuOL9P0ceBn XUAlzy060SzCD6p1gfWGXUI9tGeaeFWfc9102th5CK9frs3I/icsCB2/teT6Z5iJmGru5MHf+zm FbKUACG7BF/autBGAXeKPc04N5V++m82eHQkh9DSXYXEPEqo5rnw+TIiTxlOiJg8O+uoWYZigeT qkZb85eJ/i1RzAXCteAOhx3SPR8pPoDBMO41BedJxe8zK4hoepvMGv7Ed9RHLWGeK4x62QReY+e e9CwofvtrPulUpPPbCaq/1c9Z20CFnACdrENzOqxsG/abcjOYxhOd1Z6aP87mf0/3a2UyCEIakq y5OZSKw3EsJ3MHQKD5cDIltaTaAbacsi7Hdw9BO0H+A48Sr6VD3gU= X-Received: by 2002:a05:600c:3b9f:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-483c9ba7e4dmr63328315e9.6.1772223730908; Fri, 27 Feb 2026 12:22:10 -0800 (PST) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa82c531sm5448388a12.24.2026.02.27.12.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 12:22:10 -0800 (PST) Message-ID: <07ebe143-13a4-47f6-8935-600a7cc50797@suse.com> Date: Sat, 28 Feb 2026 06:52:01 +1030 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] btrfs: replace BUG() with error handling in compression.c To: Adarsh Das , clm@fb.com, dsterba@suse.com Cc: terrelln@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260227183111.9311-1-adarshdas950@gmail.com> <20260227183111.9311-2-adarshdas950@gmail.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20260227183111.9311-2-adarshdas950@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/2/28 05:01, Adarsh Das 写道: > Replace BUG() calls with proper error handling. Where fs_info is > available, use btrfs_err() and return -EUCLEAN. Where fs_info is > not available, btrfs_err() can accept a NULL pointer as @fs_info. [...] > > @@ -874,11 +862,8 @@ static struct list_head *get_workspace(struct btrfs_fs_info *fs_info, int type, > case BTRFS_COMPRESS_LZO: return btrfs_get_workspace(fs_info, type, level); > case BTRFS_COMPRESS_ZSTD: return zstd_get_workspace(fs_info, level); > default: > - /* > - * This can't happen, the type is validated several times > - * before we get here. > - */ > - BUG(); > + btrfs_err(fs_info, "invalid compression type %d", type); > + return ERR_PTR(-EUCLEAN); Although for such unknown compression level case, the workspace user and put_workspace() are all erroring out correctly, it's not following the common pattern of checking the error first. I'd prefer to just remove those default: branch, and add an ASSERT() checking the type is inside the BTRFS_NR_COMPRESS_TYPE before calling switch(). Just as the comment said, the @type has been verify too many times, we don't need to add a new error pattern where no one is checking. Thanks, Qu > } > } > > @@ -925,11 +910,8 @@ static void put_workspace(struct btrfs_fs_info *fs_info, int type, struct list_h > case BTRFS_COMPRESS_LZO: return btrfs_put_workspace(fs_info, type, ws); > case BTRFS_COMPRESS_ZSTD: return zstd_put_workspace(fs_info, ws); > default: > - /* > - * This can't happen, the type is validated several times > - * before we get here. > - */ > - BUG(); > + btrfs_err(fs_info, "invalid compression type %d", type); > + return; > } > } >