From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9510C001B0 for ; Thu, 13 Jul 2023 19:05:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232589AbjGMTFB (ORCPT ); Thu, 13 Jul 2023 15:05:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbjGMTE7 (ORCPT ); Thu, 13 Jul 2023 15:04:59 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB31F171D for ; Thu, 13 Jul 2023 12:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=Tunyxm7225nRlfSTHxgTZRKdYPHBEXYuY6MWqVIZLtA=; b=v9XsH4mAkY82rUYyHnv9cyZivu eTM5svjbjBnJMSPXncAe6D+e21qhbDQy3561717YRHOWE6LJXq6t2Das0jW3nywXeYg2Nc0Lj4elh Rqz35n6SJy4/VfFnXrB+ysqGYzkGrlIKsPQMPS+jhSe7vqhbglAkHaFZ8eEdkWnGBndF9W8It/QDl +Z3eJvkJ71nZghLJtjS3IEtTRKpGVAwW3auJiCct/mpJbaq8O+iP2FFy1LScGhNAyUvMNv6Y9uWWD qT4qor6+G4MkeIAe1TasFzBO7DPHFLCflul6ixFPPxOu6YQgkDWXcBc4BvhmFMbdwNDYFVfAvtoNV 002c3+rw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qK1cW-004Chy-22; Thu, 13 Jul 2023 19:04:56 +0000 Message-ID: <07f0c6ac-f195-e598-4649-e88ad5e76005@infradead.org> Date: Thu, 13 Jul 2023 12:04:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m Content-Language: en-US To: Jim Cromie , jbaron@akamai.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, gregkh@linuxfoundation.org References: <20230713163626.31338-1-jim.cromie@gmail.com> <20230713163626.31338-21-jim.cromie@gmail.com> From: Randy Dunlap In-Reply-To: <20230713163626.31338-21-jim.cromie@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jim, On 7/13/23 09:36, Jim Cromie wrote: > Signed-off-by: Jim Cromie > --- > lib/Kconfig.debug | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d4fbbcc395d2..82d11ac63758 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2696,13 +2696,14 @@ config TEST_STATIC_KEYS > > config TEST_DYNAMIC_DEBUG > tristate "Build test-dynamic-debug module" > + default m You need to justify such a change, and since it's not required for running the system, I don't think it should be 'm'. > depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE > help > This module works/demo's the dyndbg's classmap API, by > creating 2 classes: a DISJOINT classmap (like DRM.debug) > and a LEVELS/VERBOSE classmap (where 2>1). > > - If unsure, say N. > + If unsure, say N. If bored/curious, say M > > config TEST_KMOD > tristate "kmod stress tester" -- ~Randy