From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677AFCA9EC3 for ; Tue, 29 Oct 2019 12:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45EA1208E3 for ; Tue, 29 Oct 2019 12:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732187AbfJ2MJ2 (ORCPT ); Tue, 29 Oct 2019 08:09:28 -0400 Received: from mail-sh.amlogic.com ([58.32.228.43]:16887 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727681AbfJ2MJ2 (ORCPT ); Tue, 29 Oct 2019 08:09:28 -0400 Received: from [10.18.29.227] (10.18.29.227) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 29 Oct 2019 20:09:39 +0800 Subject: Re: [PATCH v3 1/4] dt-bindings: power: add Amlogic secure power domains bindings To: Rob Herring CC: Kevin Hilman , , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , , , , , Jian Hu , Hanjie Lin , Victor Wan , Xingyu Chen References: <1571391167-79679-1-git-send-email-jianxin.pan@amlogic.com> <1571391167-79679-2-git-send-email-jianxin.pan@amlogic.com> <20191029020125.GA11182@bogus> From: Jianxin Pan Message-ID: <07f0ed9d-0b1a-d84f-de8b-1967e56bbd21@amlogic.com> Date: Tue, 29 Oct 2019 20:09:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191029020125.GA11182@bogus> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.227] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerome, Could you give some advice about this? In a1/c1, watchdog and powerdomain are the same, they use secure monitor [0] and there is no share memory needed. [0] https://lore.kernel.org/linux-amlogic/20190731082339.20163-1-ccaione@baylibre.com/ On 2019/10/29 10:01, Rob Herring wrote: > On Fri, Oct 18, 2019 at 05:32:44PM +0800, Jianxin Pan wrote: >> Add the bindings for the Amlogic Secure power domains, controlling the >> secure power domains. >> >> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the >> power domain registers are in secure world. >> >> Signed-off-by: Jianxin Pan >> --- >> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 42 ++++++++++++++++++++++ >> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++ >> 2 files changed, 74 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> create mode 100644 include/dt-bindings/power/meson-a1-power.h >> >> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> new file mode 100644 >> index 00000000..88d8261 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> @@ -0,0 +1,42 @@ >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +# Copyright (c) 2019 Amlogic, Inc >> +# Author: Jianxin Pan >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-pwrc.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic Meson Secure Power Domains >> + >> +maintainers: >> + - Jianxin Pan >> + >> +description: |+ >> + Meson Secure Power Domains used in A1/C1 SoCs. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-a1-pwrc >> + >> + "#power-domain-cells": >> + const: 1 >> + >> + secure-monitor: >> + description: phandle to the secure-monitor node >> + $ref: /schemas/types.yaml#/definitions/phandle > > Like the watchdog, make this a child or the secure firmware node. Or > just add '#power-domain-cells' to it. You don't really need a child node > here if there's not other resources in DT for this. > > Rob > > . >