From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1F2C433F5 for ; Tue, 26 Apr 2022 15:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352375AbiDZPhk (ORCPT ); Tue, 26 Apr 2022 11:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348202AbiDZPhh (ORCPT ); Tue, 26 Apr 2022 11:37:37 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECD1D15A421 for ; Tue, 26 Apr 2022 08:34:29 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id 125so20379150iov.10 for ; Tue, 26 Apr 2022 08:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=OpyzjXJnk6eqe+VGPz2+jQbpqiOOVBobzQ0e/23Nzu0=; b=T9Fq/3c78FVVT1NuUKe/2UR+75umKo8M9qSNKdM6PZeYY2RzIiBKLLuj2Rxw/EuMnZ OCPMdrkPC3guaLiEAadVHyqUs69hMy4WbUxCbp1ZGSIxSmCA+p4kwhK/yZDPFBRtHsTr ptHR3sN82ZQ5yC59YnCoAp7jpJwv1VJHjjvt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OpyzjXJnk6eqe+VGPz2+jQbpqiOOVBobzQ0e/23Nzu0=; b=XHMOXeVSGtjwpwLftHttCeXZxMhypKlUdE80N/Q3JcRasr6SkpYVnx1fFQYULYqb7y DKAn0PuxDclIYfvmfP6JPfmFbQrxVmeS2WXa0BzFSSH9+tfl3MXbtYZ+7jgajdvlQJuE yljKsNuI3LGds6/GmITwpjJ+9bYk92UEKqao/jd22UsxqvFypxbQOaX6jzfJSh4aPJYx aRKEw06CUpRXzEQ+lccgvLyePAFfXnjiXkbgEfPUgoC1Kd1C+00a5S86xA1twrO8vegr Og+//3v4LsE6m2cQ+5mk67C9nGc+j1o2IprpgL0iwqcAilg4Ui8Z6ap8u6gZNnwThIwL bO5g== X-Gm-Message-State: AOAM531qYcgVIXprMjp2J70ewFKfp8Grb+qAVAOH/ErduLbJE4uP+mUy JU6FFIzgr8ZacTwpbL57+cQ9VA== X-Google-Smtp-Source: ABdhPJw9h4gM3l6CtupC/f3zfezm+mc5VNR/F8cvn/HttlJlzk/VDKwV16ujjCclml42Zq7QEbODsQ== X-Received: by 2002:a05:6e02:1d04:b0:2cc:4c42:9b99 with SMTP id i4-20020a056e021d0400b002cc4c429b99mr8843144ila.168.1650987269319; Tue, 26 Apr 2022 08:34:29 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id x9-20020a6bda09000000b006545a38b1acsm9416979iob.47.2022.04.26.08.34.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 08:34:28 -0700 (PDT) Subject: Re: [PATCH v6] media: vimc: get pixformat info from v4l2_format_info To: Hans Verkuil , "Carlos E. C. Barbosa" , Helen Koike , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220311111657.56038-1-barbosa.carlos.ec@gmail.com> <3665efc7-0b47-1adf-5639-93229af04e95@xs4all.nl> From: Shuah Khan Message-ID: <07f415c4-addb-73e8-6604-60e7eeb63abf@linuxfoundation.org> Date: Tue, 26 Apr 2022 09:34:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3665efc7-0b47-1adf-5639-93229af04e95@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Carlos, On 4/26/22 3:02 AM, Hans Verkuil wrote: > Hi Carlos, > > On 11/03/2022 12:16, Carlos E. C. Barbosa wrote: >> Removes overlapping structures >> >> Repurposes vimc_pix_map to strictly mapping formats, making it >> a local structure. >> >> Replaces all of its functions and remaps the calls to the matching >> v4l2_format_info. >> >> --- >> >> Changes in v6: >> - replace all vimc_pix_map returning functions with v4l2_format_info >> ones (as previously suggested by Dafna) >> - adds is_on_table functions to verify support (to be used only when >> no other info is required) >> >> Changes in v5: >> - .bayer member was removed and replaced by v4l2 functions calls >> >> Changes in v4: >> - Unused variables were removed >> >> Changes in v3: >> - Change declaration order of variables and some minor style changes >> >> Changes in v2: >> - Const qualifiers are not removed >> - Bayer flag is kept >> - Unnecessary changes are not made anymore >> >> v4l2-compliance -m /dev/media0 output: >> https://pastebin.com/BRjMP3wP >> >> Signed-off-by: Carlos E. C. Barbosa > > Your Signed-off-by should go before the '---'. > > Also, it doesn't match your 'From' email. > > Regards, > > Hans > > Sorry for the delay on this. In addition to Han's comments, please provide more information in your commit log on the changes and how they help in more detail. Are these changes fix any problems you may have found. thanks, -- Shuah