From: Yashas D <y-d@ti.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: <Laurent.pinchart@ideasonboard.com>, <j-choudhary@ti.com>,
<luca.ceresoli@bootlin.com>, <andrzej.hajda@intel.com>,
<krzk+dt@kernel.org>, <devicetree@vger.kernel.org>,
<s-jain1@ti.com>, <tzimmermann@suse.de>,
<linux-kernel@vger.kernel.org>, <yamonkar@cadence.com>,
<simona@ffwll.ch>, <maarten.lankhorst@linux.intel.com>,
<b-padhi@ti.com>, <airlied@gmail.com>, <jonas@kwiboo.se>,
<tomi.valkeinen@ideasonboard.com>, <sjakhade@cadence.com>,
<r-ravikumar@ti.com>, <conor+dt@kernel.org>, <u-kumar1@ti.com>,
<mripard@kernel.org>, <neil.armstrong@linaro.org>,
<jernej.skrabec@gmail.com>, <devarsht@ti.com>, <rfoss@kernel.org>,
<dridevel@lists.freedesktop.org>, <d-mittal@ti.com>
Subject: Re: Re: [PATCH v5 1/2] dt-bindings: display: bridge: cdns,mhdp8546: Add no-hpd property to the cadence bridge
Date: Tue, 28 Jul 2026 21:49:47 +0530 [thread overview]
Message-ID: <07f536f1-9a60-46a3-bc3e-fcec4bb7ce02@ti.com> (raw)
In-Reply-To: <178524895001.2116102.6714678554328277201.robh@kernel.org>
On 28/07/26 19:59, Rob Herring (Arm) wrote:
> On Tue, 28 Jul 2026 18: 12: 23 +0530, Yashas D wrote: > From: Rahul T R
> <r-ravikumar@ ti. com> > > The mhdp bridge can work without its HPD pin
> hooked up to the connector, > but the current bridge driver throws an
> error when hpd
>
>
> On Tue, 28 Jul 2026 18:12:23 +0530, Yashas D wrote:
>> From: Rahul T R <r-ravikumar@ti.com>
>>
>> The mhdp bridge can work without its HPD pin hooked up to the connector,
>> but the current bridge driver throws an error when hpd line is not
>> connected to the connector. For such cases, we need an indication for
>> no-hpd, using which we can bypass the hpd detection and instead use the
>> auxiliary channels connected to the DP connector to confirm the
>> connection.
>> So add no-hpd property to the bindings, to disable hpd when not
>> connected or cannot be used for hotplug detection.
>>
>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> Signed-off-by: Yashas D <y-d@ti.com>
>> ---
>> .../bindings/display/bridge/cdns,mhdp8546.yaml | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: [error] syntax error: mapping values are not allowed here (syntax)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: ignoring, error parsing file
> ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: error loading YAML: mapping values are not allowed here
> in "./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml", line 66, column 30
> ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: mapping values are not allowed here
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.example.dts'
> Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: mapping values are not allowed here
> make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.example.dts] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1703: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> Seehttps://urldefense.com/v3/__https://patchwork.kernel.org/project/
> devicetree/patch/20260728124224.774785-2-y-d@ti.com__;!!G3vK!W-
> t7VTYjMiEiiyA5HnNwMPXZXIDl6mIiVFQjSxqG20XM1FTyTXYmNfyADL2cjwLH7WdrUA$ <https://urldefense.com/v3/__https://patchwork.kernel.org/project/devicetree/patch/20260728124224.774785-2-y-d@ti.com__;!!G3vK!W-t7VTYjMiEiiyA5HnNwMPXZXIDl6mIiVFQjSxqG20XM1FTyTXYmNfyADL2cjwLH7WdrUA$>
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Hi Rob,
My dt_binding_check had passed, will upgrade and run it again and send a
new patch.
Thanks,
Yashas D
next prev parent reply other threads:[~2026-07-28 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:42 [PATCH v5 0/2] " Yashas D
2026-07-28 12:42 ` [PATCH v5 1/2] dt-bindings: display: bridge: cdns,mhdp8546: " Yashas D
2026-07-28 14:29 ` Rob Herring (Arm)
2026-07-28 16:19 ` Yashas D [this message]
2026-07-29 8:18 ` Krzysztof Kozlowski
2026-07-28 12:42 ` [PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Add no-hpd property Yashas D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f536f1-9a60-46a3-bc3e-fcec4bb7ce02@ti.com \
--to=y-d@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=b-padhi@ti.com \
--cc=conor+dt@kernel.org \
--cc=d-mittal@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dridevel@lists.freedesktop.org \
--cc=j-choudhary@ti.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=r-ravikumar@ti.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=sjakhade@cadence.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®