From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: 运辉崔 <cuiyunhui@bytedance.com>, "Conor Dooley" <conor@kernel.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Cc: sunilvl@ventanamicro.com, ardb@kernel.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, rminnich@gmail.com,
mark.rutland@arm.com, lpieralisi@kernel.org, rafael@kernel.org,
lenb@kernel.org, jdelvare@suse.com, yc.hung@mediatek.com,
angelogioacchino.delregno@collabora.com,
allen-kh.cheng@mediatek.com,
pierre-louis.bossart@linux.intel.com, tinghan.shen@mediatek.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
geshijian@bytedance.com, weidong.wd@bytedance.com
Subject: Re: [External] Re: [PATCH v3 4/4] dt-bindings: firmware: Document ffitbl binding
Date: Thu, 6 Jul 2023 08:00:55 +0200 [thread overview]
Message-ID: <07f88065-b9ca-5233-4048-5e61e1cdbe0c@linaro.org> (raw)
In-Reply-To: <CAEEQ3wmG1OiE3GFqQp9SP+oKUbTfuTPx=rNGd-sjKsW7vv3bew@mail.gmail.com>
On 06/07/2023 05:43, 运辉崔 wrote:
> Hi Conor,
>
> Added dts Maintainers,
>
> On Wed, Jul 5, 2023 at 11:07 PM Conor Dooley <conor@kernel.org> wrote:
>>
>> Hey,
>>
>> On Wed, Jul 05, 2023 at 07:42:51PM +0800, Yunhui Cui wrote:
>>> Add the description for ffitbl subnode.
>>>
>>> Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
>>> ---
>>> .../devicetree/bindings/firmware/ffitbl.txt | 27 +++++++++++++++++++
>>> MAINTAINERS | 1 +
>>> 2 files changed, 28 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/firmware/ffitbl.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/firmware/ffitbl.txt b/Documentation/devicetree/bindings/firmware/ffitbl.txt
>>> new file mode 100644
>>> index 000000000000..c42368626199
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/firmware/ffitbl.txt
>>
>> Firstly, new dt-bindings need to be done in yaml, not in text form.
>> Secondly, you didn't re-run get_maintainer.pl after adding this binding,
>> so you have not CCed any of the other dt-binding maintainers nor the
>> devicetree mailing list.
>
> Re-run get_maintainer.pl and added maintainers into the maillist.
This does not work like this.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
> emm.. There is some *txt in
> Documentation/devicetree/bindings/firmware/, isn't it?
And what about it? Do you claim they were added recently?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-06 6:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:42 [PATCH v3 0/4] Obtain SMBIOS and ACPI entry from FFI Yunhui Cui
2023-07-05 11:42 ` [PATCH v3 1/4] riscv: obtain ACPI RSDP from devicetree Yunhui Cui
2023-07-05 11:42 ` [PATCH v3 2/4] firmware: introduce FFI for SMBIOS entry Yunhui Cui
2023-07-05 11:42 ` [PATCH v3 3/4] riscv: obtain SMBIOS entry from FFI Yunhui Cui
2023-07-05 11:42 ` [PATCH v3 4/4] dt-bindings: firmware: Document ffitbl binding Yunhui Cui
2023-07-05 15:06 ` Conor Dooley
2023-07-06 3:43 ` [External] " 运辉崔
2023-07-06 6:00 ` Krzysztof Kozlowski [this message]
2023-07-06 6:24 ` 运辉崔
2023-07-06 6:41 ` Krzysztof Kozlowski
2023-07-06 6:55 ` 运辉崔
2023-07-06 6:44 ` Conor Dooley
2023-07-06 9:02 ` 运辉崔
2023-07-07 16:16 ` Conor Dooley
[not found] ` <CAN3iYbP_dQOOJKLjAf+pVeYUZRBqwZBG7eq6=pR0upsjT2GpOA@mail.gmail.com>
2023-07-08 3:04 ` [External] " 运辉崔
2023-07-08 8:09 ` Conor Dooley
2023-07-05 14:17 ` [PATCH v3 0/4] Obtain SMBIOS and ACPI entry from FFI Palmer Dabbelt
2023-07-05 15:33 ` Conor Dooley
2023-07-06 2:04 ` [External] " 运辉崔
2023-07-06 8:53 ` Ard Biesheuvel
2023-07-06 15:32 ` Palmer Dabbelt
[not found] ` <CAP6exYKwZG=_47r0jAUFYNL5-P-SS==k6vWdKiMJ9nB0upH5Zw@mail.gmail.com>
2023-07-06 21:47 ` Conor Dooley
2023-07-06 21:53 ` ron minnich
2023-07-07 8:38 ` Conor Dooley
2023-07-07 10:43 ` Sunil V L
[not found] ` <CAN3iYbMhQU5Ng4r6_rQDnLmit1GCmheC5T49rsUP5NgHFEXsHA@mail.gmail.com>
2023-07-07 12:55 ` Sunil V L
[not found] ` <CAN3iYbOe+i4jVhz0sSQwVQ2PMB7UvaTPyN_sLtZj0uiOD2emDA@mail.gmail.com>
2023-07-07 16:07 ` Conor Dooley
2023-07-07 16:18 ` 葛士建
[not found] ` <DBAPR08MB57836AE63A1F5D3902B95BFE9C2DA@DBAPR08MB5783.eurprd08.prod.outlook.com>
2023-07-08 3:22 ` 运辉崔
2023-07-08 3:58 ` [External] " Jessica Clarke
2023-07-08 9:25 ` 运辉崔
[not found] ` <DBAPR08MB5783AED8329E38D840B7015D9C2DA@DBAPR08MB5783.eurprd08.prod.outlook.com>
2023-07-07 16:24 ` [External] " Conor Dooley
2023-07-08 8:45 ` Ard Biesheuvel
2023-07-08 12:03 ` Sunil V L
2023-07-08 15:19 ` Dong Wei
2023-07-08 16:26 ` Palmer Dabbelt
2023-07-10 16:03 ` 葛士建
2023-09-07 12:15 ` yunhui cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f88065-b9ca-5233-4048-5e61e1cdbe0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=cuiyunhui@bytedance.com \
--cc=devicetree@vger.kernel.org \
--cc=geshijian@bytedance.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rminnich@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tinghan.shen@mediatek.com \
--cc=weidong.wd@bytedance.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®