mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
To: Le Qi <le.qi@oss.qualcomm.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com
Subject: Re: [PATCH] ASoC: qcom: sc8280xp: configure codec sysclk for QCS615
Date: Fri, 7 Aug 2026 15:35:51 +0530	[thread overview]
Message-ID: <07f94571-ecd1-40a2-b47c-a732cd439b54@oss.qualcomm.com> (raw)
In-Reply-To: <20260807012450.1038180-1-le.qi@oss.qualcomm.com>



On 8/7/2026 6:54 AM, Le Qi wrote:
> Continuous high-amplitude noise could occur in the DA7213 microphone
> capture path after a Bluetooth out-of-range/reset event followed by
> reconnection. The noise was present in both the raw ALSA capture and
> PipeWire input, confirming that it originated before Bluetooth
> encoding.
> 
> The codec already obtains and enables MCLK through its DT clock and
> bias-level handling. However, the machine driver did not explicitly
> configure the codec sysclk during hw_params(). Enable
> codec_sysclk_set for QCS615 so that the DA7213 clock source and rate
> are configured before the codec power-up sequence.
> 
> Verified on QCS615 Talos with repeated Bluetooth disconnect and
> reconnect cycles. The noise was no longer reproducible.
> 
> Signed-off-by: Le Qi <le.qi@oss.qualcomm.com>
> ---
> This patch depends on:
> 
> ASoC: qcom: sc8280xp: enhance machine driver for board-specific config
> 
> Link: https://lore.kernel.org/r/20260727151230.408122-4-mohammad.rafi.shaik@oss.qualcomm.com/
> 
> The prerequisite patch introduces qcs615_priv_data and the
> codec_sysclk_set field used by this change. It has not yet been merged
> into linux-next.


Drop this dependency flag, as the change has already been applied.

Thanks & Regards,
Rafi.

> 
>   sound/soc/qcom/sc8280xp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index cf272d0612fe..8d949e4dec5b 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -306,6 +306,7 @@ static const struct snd_soc_common qcs615_priv_data = {
>   	.driver_name = "qcs615",
>   	.dapm_widgets = sc8280xp_dapm_widgets,
>   	.num_dapm_widgets = ARRAY_SIZE(sc8280xp_dapm_widgets),
> +	.codec_sysclk_set = true,
>   };
>   
>   static const struct snd_soc_common qcm6490_priv_data = {


  reply	other threads:[~2026-08-07 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  1:24 Le Qi
2026-08-07 10:05 ` Mohammad Rafi Shaik [this message]
2026-08-07 21:36 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07f94571-ecd1-40a2-b47c-a732cd439b54@oss.qualcomm.com \
    --to=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=le.qi@oss.qualcomm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®