From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA406C433E1 for ; Mon, 27 Jul 2020 21:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C87FE20786 for ; Mon, 27 Jul 2020 21:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbgG0VHI (ORCPT ); Mon, 27 Jul 2020 17:07:08 -0400 Received: from smtprelay0238.hostedemail.com ([216.40.44.238]:52336 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726176AbgG0VHI (ORCPT ); Mon, 27 Jul 2020 17:07:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 6840F1730856; Mon, 27 Jul 2020 21:07:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: alarm14_620d22a26f64 X-Filterd-Recvd-Size: 1700 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Mon, 27 Jul 2020 21:07:06 +0000 (UTC) Message-ID: <0801ef9d2489ed816ec97ee3054de2d20bfac14c.camel@perches.com> Subject: Re: [PATCH] checkpatch: improve MAINTAINERS file update test From: Joe Perches To: Daniel Dadap , apw@canonical.com Cc: LKML Date: Mon, 27 Jul 2020 14:07:05 -0700 In-Reply-To: <20200727205856.28343-1-ddadap@nvidia.com> References: <20200727205856.28343-1-ddadap@nvidia.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-07-27 at 15:58 -0500, Daniel Dadap wrote: > Add an additional regular expression to detect updates to the > MAINTAINERS file as reported in the unified diffs generated by > `git format-patch`. This suppresses the "does MAINTAINERS need > updating" message when MAINTAINERS is updated with this format. Please cc at least LKML. > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -2621,7 +2621,8 @@ sub process { > > # Check if MAINTAINERS is being updated. If so, there's probably no need to > # emit the "does MAINTAINERS need updating?" message on file add/move/delete > - if ($line =~ /^\s*MAINTAINERS\s*\|/) { > + if ($line =~ /^\s*MAINTAINERS\s*\|/ || > + $line =~ /^[-+]{3} [ab]\/MAINTAINERS$/) { I don't believe this works well as any test for a file modification to MAINTAINERS occurs after the block that would show a diffstat where the warning is emitted.