From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44DC3C4167B for ; Mon, 27 Nov 2023 02:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbjK0CwF (ORCPT ); Sun, 26 Nov 2023 21:52:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbjK0CwB (ORCPT ); Sun, 26 Nov 2023 21:52:01 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA20134 for ; Sun, 26 Nov 2023 18:52:06 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6d81fbfe7aaso465647a34.1 for ; Sun, 26 Nov 2023 18:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1701053526; x=1701658326; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qI9CcSDLLstHRyj21IWoZ+bA+1wKLNybWTEpCFykIso=; b=SPyMhDEtqbnpufUeiooy6qsseAPLl3eau1IO7W7a1RwA9xAzWZYGzbuTYpmUWM5FDb 38PX7DCRFuqKLZ7mm7noViyo6kP9LW2mtLBseJix2FuRkFrg+zgRzWJ6ppw4SzSy12dW UDlSzr70y5fuarXbg1xRvOqiF6cpOXejAc1Zysl+aGWkK33d15qco4FT6MxXRJu6jsvg Lqf+i/EIUnu/4/O2yAH3nU7Yc1Bcya9a5K+TbUUSRhiKnW5IGqZdqqYNOqBrlNFamjBM 7MQUnuZcQtfgE0mNr1XoE/r1FPM8GxsEYJX2zgS4isGgDKnBlz09FlaGnXvLOPFh3sc3 UzrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701053526; x=1701658326; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qI9CcSDLLstHRyj21IWoZ+bA+1wKLNybWTEpCFykIso=; b=ZLO+EIU7RQ1xITfTXbhdAXNFpcuqFM4Z+44ZGRZpuEbEiA4y4ni94v/lX39oz1fZCd yBN8Q74Pkq9vjudNzwCtgMlGY2spV0GbtC6hCnGfp2rebNHTjnjMGe75nHX1U/G/dIG4 e20brF8UjHDr/t255XhWntGjBFHhZVdCbVvKvpVPNmOLymSEvjTD/KoJiVUa/G1T7x03 RG6cEOt8sVr93vqBX2vVWzlLWRqBVEA1K8n2NmiuK4wEpo3c1jhC7L6pScJymh9ojPD6 9ce+06QnWhcOT44ObXKq5KhCLJgrH8jnJ/GyR4gmLC0Yb2+fbsdMh5/Bne5fsNxIdOgx NQDQ== X-Gm-Message-State: AOJu0YzT0MM/oLr+uVOpDMc8ET5L1ZAj6X5QCvhJ6lBgh0ZvJqhG4LEf r2kjmy3vG0aj9JLfe4/X/6SBWg== X-Google-Smtp-Source: AGHT+IEUMWOQwI01s5hv1fkkX+qTkj8fVqbeaE2jyE5V20loSNf/HwB1dt15pdwtT8kBz5cVsoeurg== X-Received: by 2002:a05:6870:9a90:b0:1fa:82:3d6b with SMTP id hp16-20020a0568709a9000b001fa00823d6bmr12180340oab.9.1701053525800; Sun, 26 Nov 2023 18:52:05 -0800 (PST) Received: from ?IPv6:2402:7500:4ce:95c7:2856:b238:775:b338? ([2402:7500:4ce:95c7:2856:b238:775:b338]) by smtp.gmail.com with ESMTPSA id c13-20020a631c4d000000b0058988954686sm6632076pgm.90.2023.11.26.18.52.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Nov 2023 18:52:05 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.7\)) Subject: Re: [PATCH 06/12] RISC-V: crypto: add accelerated AES-CBC/CTR/ECB/XTS implementations From: Jerry Shih In-Reply-To: <20231122011422.GF2172@sol.localdomain> Date: Mon, 27 Nov 2023 10:52:00 +0800 Cc: Paul Walmsley , palmer@dabbelt.com, Albert Ou , herbert@gondor.apana.org.au, davem@davemloft.net, andy.chiu@sifive.com, greentime.hu@sifive.com, conor.dooley@microchip.com, guoren@kernel.org, bjorn@rivosinc.com, heiko@sntech.de, ardb@kernel.org, phoebe.chen@sifive.com, hongrong.hsu@sifive.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <08090C1A-E8D9-4C87-995B-8A7A195CE1AF@sifive.com> References: <20231025183644.8735-1-jerry.shih@sifive.com> <20231025183644.8735-7-jerry.shih@sifive.com> <20231102051639.GF1498@sol.localdomain> <20231122011422.GF2172@sol.localdomain> To: Eric Biggers X-Mailer: Apple Mail (2.3445.9.7) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 22, 2023, at 09:14, Eric Biggers wrote: > On Wed, Nov 01, 2023 at 10:16:39PM -0700, Eric Biggers wrote: >>> + Architecture: riscv64 using: >>> + - Zvbb vector extension (XTS) >>> + - Zvkb vector crypto extension (CTR/XTS) >>> + - Zvkg vector crypto extension (XTS) >>> + - Zvkned vector crypto extension >> >> Maybe list Zvkned first since it's the most important one in this context. > > BTW, I'd like to extend this request to the implementation names > (.cra_driver_name) and the names of the files as well. I.e., instead of: > > aes-riscv64-zvkned > aes-riscv64-zvkb-zvkned > aes-riscv64-zvbb-zvkg-zvkned > sha256-riscv64-zvkb-zvknha_or_zvknhb > sha512-riscv64-zvkb-zvknhb > > ... we'd have: > > aes-riscv64-zvkned > aes-riscv64-zvkned-zvkb > aes-riscv64-zvkned-zvbb-zvkg > sha256-riscv64-zvknha_or_zvknhb-zvkb > sha512-riscv64-zvknhb-zvkb > > and similarly for the cra_driver_name fields. > > I think that's much more logical. Do you agree? > > - Eric Fixed. We have the names like: aes-riscv64-zvkned aes-riscv64-zvkned-zvkb aes-riscv64-zvkned-zvbb-zvkg sha256-riscv64-zvknha_or_zvknhb-zvkb sha512-riscv64-zvknhb-zvkb -Jerry