From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E863EC00449 for ; Wed, 3 Oct 2018 10:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6B1920645 for ; Wed, 3 Oct 2018 10:50:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B1920645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbeJCRic (ORCPT ); Wed, 3 Oct 2018 13:38:32 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49430 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbeJCRic (ORCPT ); Wed, 3 Oct 2018 13:38:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DB6318A; Wed, 3 Oct 2018 03:50:41 -0700 (PDT) Received: from [10.4.13.99] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B6423F5A0; Wed, 3 Oct 2018 03:50:40 -0700 (PDT) Subject: Re: [PATCH v8 1/9] KVM: arm/arm64: Ensure only THP is candidate for adjustment To: Punit Agrawal , kvmarm@lists.cs.columbia.edu Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Christoffer Dall , stable@vger.kernel.org References: <20181001155443.23032-1-punit.agrawal@arm.com> <20181001155443.23032-2-punit.agrawal@arm.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <0809a9d0-d256-c23a-c3cc-0b2be33aecff@arm.com> Date: Wed, 3 Oct 2018 11:50:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181001155443.23032-2-punit.agrawal@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/18 16:54, Punit Agrawal wrote: > PageTransCompoundMap() returns true for hugetlbfs and THP > hugepages. This behaviour incorrectly leads to stage 2 faults for > unsupported hugepage sizes (e.g., 64K hugepage with 4K pages) to be > treated as THP faults. > > Tighten the check to filter out hugetlbfs pages. This also leads to > consistently mapping all unsupported hugepage sizes as PTE level > entries at stage 2. > > Signed-off-by: Punit Agrawal > Reviewed-by: Suzuki Poulose > Cc: Christoffer Dall > Cc: Marc Zyngier > Cc: stable@vger.kernel.org # v4.13+ FWIW, I've cherry-picked that single patch from the series and queued it for 4.20. Thanks, M. -- Jazz is not dead. It just smells funny...