From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC58D1EE7B7 for ; Tue, 7 Jan 2025 13:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736255790; cv=none; b=qbE2H3hZNq2hEd5RTncpDrfCvHZwhv9JQDFwlf+uHNnLSy0we7nCD9v0plQYSRHZBLxFJHI0wactWhbz/5omZSetSPyX/aWNOCRiVYuaOy+wn+BnOUbl9Lqtp+pQfjtAa2UusziCSFnML29qQ5nmjGYe/mk/4pl+T2qwgaKefnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736255790; c=relaxed/simple; bh=cQmF+qfwQ5oZ2UGWqaKTp/0Eyn+/UskPrCQV17jODPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HZpo0NB52+X5NdYoFu5KWElTw4cvPHboYinuvkw4kyJQrjdyFlBZcYHMDXpTA7dlG8OEzi2CJPMbdSHuggvHpCxd/otJqIkzRXi6WCIoa2s9hOvr1XaOaNgePhSsEJoW/C3b20mb5PMkmucPC9XWyojI8BaIJ9UiyjnofQWhmnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=A+or0MPz; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="A+or0MPz" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2156e078563so197080015ad.2 for ; Tue, 07 Jan 2025 05:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736255787; x=1736860587; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Xh/DU844Fo6v/U3voWcatL10AQvLHJrDR1/f3hiSEoA=; b=A+or0MPz7BkEfiYRBEqb8uIk+UawdDq54J9lxWIcV0+bL7/zaQddHRDAE9mIxiDjnI qT1NU9t8zZZHqOraMuBo1UxXeCxFRGyE2skfbZRzt7BuSszJKXfWW97BCEZsoP2rI4Pc MLrJBqsY0NQwWR5CTWrx/xFSCOnB9GprjIVwYrJ76Aitb6DMVSCtBVgZDRBSM+EHJC8J Zley337i2JxArckKdc7gu6TpijcPuGTBxGNwFpcz8tDfy/Vntr0s9QJX1fXc82KVPtH5 EeoxQ/UUT68eLlFaySBR4J/Y1XsTnOOeyjf2Zv4z4dTDGJTttuF9zEX02zlmjp3hsvlT ocSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736255787; x=1736860587; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Xh/DU844Fo6v/U3voWcatL10AQvLHJrDR1/f3hiSEoA=; b=FIUW9cmEKJ2SpMRS6HTz6rDB+yXhOfERXQSuWAGJBQ5NiGRKkoHrOs6k6/LrtORo29 a5QQW5tw/FN25G+QP/T69zKDECC+Y9Cqq2lYgl4rAbr4cqzBeTYb7xjo7TnrJVJ7Yc7X hHHhrZF7s+HLwdOrcmSp0UttxepF/7IA5WOuOruQXWThRaGeeqguxS5gm2+ma13yxIBA rAyNzVROgw0ibxBrq1RpGVChmEDufTXGlHPGW8sj7yzDQlQiT9k0aX6f/b0STNWB90Bj ExH3AAbt1D0rsOQPxNiJtQDq9Id2tlGqjW7PM4uVW3L1MpUzmUyst+pBfP8a1gPbzVKw F1tw== X-Forwarded-Encrypted: i=1; AJvYcCWeQG9RC3DWXDYlQrN6Skq2/7XnGVE3S/+Gfcl//Ab3+f4aD6clYnA5S+Vuqna8gFyTDFhBBjjuHY9fGow=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1CgB6TfOQBoL5c41UTE8Z8TzpE5G2h7Gy2XZq0UjMJkr0bhpw PL2YkcEBrw3pMPSHeWZ+VdFAkc3YD7aYlAKpUspFfK5kZXOYnUuLYWbAUvzRKYs= X-Gm-Gg: ASbGncvPj+ihnKQRkomUITcFuNxgj5/hgyP3bpftb6byxdx1ha1o1V8bZ8XDadbjqE6 /jNrkJD8a64PaDdKVp4pkYVIsepsgJAb/7nPWyrzcfanCGus5Lc/B/LUAa8W90gJd5Bj3J65Lw2 +aWINBuVX6oS703ZHbXVL83YPuuiYxeLa+wpyG/TTeqAOdyXfzCOro/CSSnppuQ95uu1LIX3Ziv YzxBNgdtuHgUJxZ2DyVT6pS9t9aHnfqgOQQQxmtCPw7DeCXK8ooGDZlE+m8Q0fJgASj2Ylop4UT XAGd4Q== X-Google-Smtp-Source: AGHT+IEikwrjtINNTE7PbP0EOn8L31LXoZSk7FxZDejF+/KsduTXGj54bknK73xgzLfgslH533g+9w== X-Received: by 2002:a17:902:ea10:b0:215:72a7:f39f with SMTP id d9443c01a7336-219e6f108c9mr820517535ad.36.1736255786880; Tue, 07 Jan 2025 05:16:26 -0800 (PST) Received: from [10.84.152.18] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f4a2csm311933095ad.175.2025.01.07.05.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 05:16:26 -0800 (PST) Message-ID: <080a07db-eb8a-4148-9ca1-2e047cab2569@bytedance.com> Date: Tue, 7 Jan 2025 21:16:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] sched/fair: Ignore isolated cpus in update_numa_stat To: Madadi Vineeth Reddy Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, longman@redhat.com, riel@surriel.com, chengming.zhou@linux.dev, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org References: <20250103065930.413464-1-zhouchuyi@bytedance.com> <20250103065930.413464-3-zhouchuyi@bytedance.com> From: Chuyi Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Madadi Vineeth Reddy, 在 2025/1/6 02:52, Madadi Vineeth Reddy 写道: > On 03/01/25 12:29, Chuyi Zhou wrote: >> Now update_numa_stats() iterates each cpu in a node to gather load >> information for the node and attempts to find the idle cpu as a candidate >> best_cpu within the node. >> >> In update_numa_stats() we should take into account the scheduling domain. >> This is because the "isolcpus" kernel command line option and cpuset iso- >> late partitions can remove CPUs from load balance. Similar to task wakeup >> and periodic load balancing, we should not involve isolated CPUs in NUMA >> balancing. When gathering load information for nodes, we need to ignore the >> load of isolated CPUs. This change also avoids selecting an isolated CPU >> as the idle_cpu. > > If possible, would you be able to share any performance metrics or benchmarks > that demonstrate the impact of this patch on NUMA balancing or CPU migration > efficiency? > > Thanks, > Madadi Vineeth Reddy > This change will not alter the default behavior of NUMA balancing unless we enables both NUMA balancing and isolated CPUs features. Therefore, under normal default conditions, there should be no performance regression. On the other hand, involving isolated CPUs in NUMA balancing or load balancing is inappropriate, and this is the issue that this patch aims to fix. It might be worth setting up a test scenario for cases where NUMA balancing and isolated CPUs are both enabled. Perhaps this testing will be done later on. Thanks.