From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp2.math.uni-bielefeld.de (smtp2.math.uni-bielefeld.de [129.70.45.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC74713D893; Thu, 26 Dec 2024 22:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=129.70.45.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735253999; cv=none; b=UfW0q0Q7kerGnOqn6kQLqSVBBckPK3laFPeaFiLQYk6dJIL9bKqZ/mZVV9CTGu1n5IT1NgnPz+Rtn7IS8qXy07fR37kNAmclxsMLZPqwRcIKnV9VhUG+NCCtdEz3L/hIq1SZq2mzKomYzaGwG3CbxfxEdaltRZhWMmIr5mCyuF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735253999; c=relaxed/simple; bh=fMTITeIo7FjkOkvVHCW/BcKPe5Bfr85KEnmK+O9mb4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jtpbZx9AZEd4prjXarT2lIjxxfMBEeWy0E2myRIXTpUgWCpt9i8kE7Ry8dEFQusL86AKjCti8HKnKAKByWUuuHOudvJAWTf03jk/sZNOW8ufvBnSSpgTT/OB1SVRhojWTmm8bs501wAM2fd8lBb5fQXFK6YTy32euNb82H91g0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=math.uni-bielefeld.de; spf=pass smtp.mailfrom=math.uni-bielefeld.de; dkim=pass (2048-bit key) header.d=math.uni-bielefeld.de header.i=@math.uni-bielefeld.de header.b=skoHUG0K; arc=none smtp.client-ip=129.70.45.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=math.uni-bielefeld.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=math.uni-bielefeld.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=math.uni-bielefeld.de header.i=@math.uni-bielefeld.de header.b="skoHUG0K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=math.uni-bielefeld.de; s=default; t=1735253994; bh=fMTITeIo7FjkOkvVHCW/BcKPe5Bfr85KEnmK+O9mb4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=skoHUG0KK1CgLzXdV4LfkTdhNGm3CuYz2WtssjNcK1eqqQel5IrN0/fV7I8404MPH XYwMsRH3WjbhTP+jAyuMULd01di+tVZ7qvsH+ne+zq6aOBbdz5EsJx4On8vZrvCe2p 2++SXI7+kC7QmLnx+f3nCE4ZyqSqFPk3aSC3Kp4/fztMkgRJ2tJDucXQZvAimqcftM pSL2KVmFe0xVO0M9B0VApUPX8plWtdnzjavIXxJYKoQXAvdlD7oAlloRRUH/GBKuSx qKQatULZiFy+lOpwZx39p5bLhO5wvqmv5TaIB6xfF3z0ISL7Zt9M51q+BYuaDBPEAW ylKr1dqNuVK2Q== Received: from [192.168.2.10] (58-32-133-N4.customer.vsm.sh [170.133.32.58]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by smtp2.math.uni-bielefeld.de (Postfix) with ESMTPSA id 3D06920567; Thu, 26 Dec 2024 23:59:54 +0100 (CET) Message-ID: <080bad40-6676-4369-9601-d2d200ae3ea2@math.uni-bielefeld.de> Date: Thu, 26 Dec 2024 23:59:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] hwmon: (oxp-sensors) Separate logic from device-specific data To: Guenter Roeck Cc: Derek John Clark , =?UTF-8?Q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <90a41ea2-9a83-4245-88c7-b8dd97f5aabf@roeck-us.net> Content-Language: en-US From: Tobias Jakobi Autocrypt: addr=tjakobi@math.uni-bielefeld.de; keydata= xsFNBFZhiNQBEAC5wiHN+jpZllNh3qv6Ni+32m4begD1A51ezJGHvubpy04S7noJ3BZvGeMf VBgp0ap0dtF3LHHKb5DRhakxU95jv3aIgVZCPztsZP7HLwwwdfI56PAy3r8IyvMxgokYZczM lPWcgYxV/cous+oLX/QjeTQ8GKkZqEfg0hK/CiBjenmBzc0BB2qlalMQP333113DIPYPbD97 3bA94/NBLlIf4HBMvvtS65s5UUtaAhnRBJ31pbrZnThwsQBktJp6UunOWGpvoPGJV5HYNPKg KKyuXkJbcN8rS3+AEz1BIlhirl+/F4MZKootDIE+oPmVtgY7wZWwHTatEgjy6D/DKgqUsfwW W/6jqYpOHRTw1iRh/vVvQ6/NCALwy0hlQWPSrA2HwjJSjwotv92mEG7+jQAjAbnFR9kaIaQa g4svIlP//hRb1ISloTl+/H5lnep2Jb3/fVS6sNEnaXVvPdcC1gUVddyMN7sJOgzn6IM6vx6l jq50hT3lIiTnKSqxOV7uNQdF85k43M208FT63GMKHJAmWsfPCOZJCY+tmkl5ezeN43iZ9W0q rsvaFpTtM4Aupjs826OIsx07PmCQFG5UtFVYK1ApoRzCp01zkW/UDN/Y1knC6SMvqY2O2u2J nhTG3+oTyvkpWtd4b1ozcUw7WNt2fY4xVXnt6yYvj+UcxEE2qwARAQABzS1Ub2JpYXMgSmFr b2JpIDx0amFrb2JpQG1hdGgudW5pLWJpZWxlZmVsZC5kZT7CwZUEEwEIAD8CGyMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEGeEB3B9OrXiyOyWfPuG7f7PKIigFAmPSu4QFCREzmbAA CgkQPuG7f7PKIiin8A//T6QUEDzmhEJr4LiHVFNLbZZk37LJRV5zhyISiwXSlvn/0L5SI3ZK jkpXXrBm3sviiW2mjw2lxRvQ9lMNwPuDvRUPtqELoWOOaEqYixPzZ8We4wE3diJ0xA/VnqLE khyF8UHHgnyk8TQ5486R6ybslRSoWyCCsrSemn5VYryDPC1w+TODb+Hb+snRQkC5UoEIVhMr IleDjHECUpC+ldGebabzBiy28oHpqrGJzme4DmSv2IrgZg339FdduUhZAeIigD33Q5lj4l6+ i/JyXX54NE34GZSjekmb6B5SmGhsAyILgumWcEpEtSDMz3mFybfOs313rYDn7OiQfrdQnzNO FKezGfBeb1Xs8EqMVBjLHN+cY8JV160kvykDo2jHwLnPGx2BHae16nepfof2Zif7sEcEZfw0 yvVwi2NYbviO8H0Zpgz1sbRv/t8k+INeZ7S2n7UMoC0g1PBdV4QrPql/iETBab907Bg63b0H /KfQMHpHe78OQsNYFkRqfjWy3Z/vZj+rrJsulscIqMyLoHHcgK3W9z9/inE7Qu65SRpvwdk2 qJzEbcQJNt/KQ3q75SoDMjpLFaSrMeWNVqtKJf+2qJL21ATf6ptM43B9YSxYsiD2BYSlyyhE iMkh85kD5jMK/HZ+p6u3jKLMXRcRstZz4FhAqFR6CBE5jbxE9hvfYL/OwU0EVmGI1AEQAMw4 NG4e0lhPiy9C7ig0vwTA6IkU8LI6SiXmt90iZg+zi2vYTihz+WHqqDsFKIz8nw1vOC4sdIzJ 8Sek623B178XOyATJ4Z2kF4FjzMbtzlAb965xdfE4vFIqgW89Dze/rv/eQ0UHuIKLu1ere9r B5ji8Sd9wksM81+MJI5Wd5OWpAmRk3DJrs1S3haZHbQzkAvjRaXlboSex7az3TIFU0JNFrTE Ym1AeM3kuJP4L2kcx7DtkzIf+kuL4w1L2RXaq0J/XiOoygTUD4MKy4iQZt2aLXqNvxbA0I4E jRvN82peVkHd/JcoygLkLecj7w1QZXY3vtLYmK5aF/mAGXpmpOMoMUPv5nyRVubzw0XAktYz 6suh/kv+t4FSSLDxKYL31j2iuckBwK6b+JQ5MQv5bLiyV+4knqAf8kaeVlbnrfiaeBKl6iZG tsezb7HoJdDi3vL9W8tgY21v/6/usvR48YjIUieiTdQvMP+SIkLPps+vgIurm0cdTxg5aPBs cObGf3v1sfXoZO9kXgzZh0OOmzM6eQMLEIg+/fGq3ceBNYGWe2CEy/dJYPfp+j1kRDa10RKz DS4O5Sed8+EoL2uBcR9MZZrQKXSeBRkcdcr9pmWYLtZeYA5eHENZ5cI9B4p1y/Ov5tbyhb4b aoY8AA4iJQL13PpLIpxCCX4nWZHOa6ZBABEBAAHCwXwEGAEIACYCGwwWIQQZ4QHcH06teLI7 JZ8+4bt/s8oiKAUCY9K7jwUJETOZuwAKCRA+4bt/s8oiKKl7EACea757C9t20wzdd7RBi8h2 jSssAni/y0/AaozghdfZPdcv4uAmC/hOO3kahgQMUkdZTLdujfdgvqMNsxXkWiyMSEUHjA6U jJ92ZcMj3d1gw6wtO5ao83O+sprKDDziLYfLb/5hAWjuPxILSM1zDYAYRwYMpqhjwvyqUM+K I04Ezm2aEIv+6DiW6LRvf03RvTcrBd6Xrtk447DudJs7XDpWi8KRQ6Ms2YaxY8sn4EnH1liD zVq3P50nSBq0UnlGSNKKdsGzr4Gb/gPFH4gseLkFdBFaVW8dIYJIdKECSsBEdjffCgAZ3L0E NNOwF3iuzP+DD8bpm5O+sv3w/+3zyPR8vicIYwTdVqNQ+6x4SjE5XE120ism/wBh1Dk2AZS7 Ko3ECxOfe+RQMLQcT9015SHgEXtte3KjqjZgvGlVRQo8MiiZChytCw+GjYbDVcH3VEZJjjtJ wSPApza1G6eKNbwbhk3I0DyqvLKeqktRvOaP1DjiuJDQ0gVWk10oyjMXvQ2zHqKiLGsrfLla pC4w+Ho/cC8OJpuwHWXqg9a3Hs6yH+hLjM/M0yk1vhMyYYXubgMv3DgbNuXAURjQ6DkY1o/8 5jyYIbLNVBjZKDXq8pN13q6/M9q8MAD2qO3VvMjyEkzypg4qB76YLoiWtsanpUBrp9bYQXQ5 JRHWPGCL3BhOxQ== In-Reply-To: <90a41ea2-9a83-4245-88c7-b8dd97f5aabf@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/26/24 21:54, Guenter Roeck wrote: > On Thu, Dec 26, 2024 at 06:00:16PM +0100, tjakobi@math.uni-bielefeld.de wrote: >> From: Tobias Jakobi >> >> We currently have large switch-statements in all functions that >> write to EC registers, even though the bulk of the supported >> devices functions more or less the same. >> >> Factor the device-specific data out into a struct oxp_config. This >> only leaves logic in the corresponding functions and should make >> adding future devices much easier and less error-prone. >> >> Also introduce struct oxp_data which is going to be used in a >> later commit to cache device state. >> >> Signed-off-by: Tobias Jakobi >> --- >> drivers/hwmon/oxp-sensors.c | 517 +++++++++++++++--------------------- >> 1 file changed, 215 insertions(+), 302 deletions(-) >> > ... >> + >> static const struct dmi_system_id dmi_table[] = { >> { >> .matches = { >> DMI_MATCH(DMI_BOARD_VENDOR, "AOKZOE"), >> DMI_EXACT_MATCH(DMI_BOARD_NAME, "AOKZOE A1 AR07"), >> }, >> - .driver_data = (void *)aok_zoe_a1, >> + .driver_data = (void *)&config_aok_zoe, > > I have not looked at hte rest of the code, but the whole point of > void * is that a tyoe cast to or from it is not necessary. > > Guenter I'm also not happy with the cast. But it's either the cast or a warning, that the const qualifier is lost. I'm open to suggestions here. But I don't think that leaving warnings around is a good idea. With best wishes, Tobias