From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756292AbcH2AhS (ORCPT ); Sun, 28 Aug 2016 20:37:18 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:35380 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756089AbcH2AhP (ORCPT ); Sun, 28 Aug 2016 20:37:15 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: xzy.xu@rock-chips.com X-FST-TO: mark.rutland@arm.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: xzy.xu@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain To: Shawn Lin , ulf.hansson@linaro.org, robh+dt@kernel.org, heiko@sntech.de References: <20160827134103.28160-1-xzy.xu@rock-chips.com> <20160827134103.28160-2-xzy.xu@rock-chips.com> <40f46bd6-22d2-f008-602a-47200340f733@rock-chips.com> Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland From: Ziyuan Xu Message-ID: <080c7a5c-7ff6-175b-e7d9-a9c7efec3afe@rock-chips.com> Date: Mon, 29 Aug 2016 08:36:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <40f46bd6-22d2-f008-602a-47200340f733@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年08月27日 22:50, Shawn Lin wrote: > On 2016/8/27 21:41, Ziyuan Xu wrote: >> Add power domain as a optional property for sdhci-of-arasan, which can >> be truned off in the so-called unused condition, such as suspend and >> remove. Aim to lower power requirements. >> >> Signed-off-by: Ziyuan Xu >> >> --- >> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index 3404afa..3f5189c 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -1,12 +1,14 @@ >> Device Tree Bindings for the Arasan SDHCI Controller >> >> - The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] >> bindings. >> + The bindings follow the mmc[1], clock[2], interrupt[3], phy[4] and >> power >> + domain[5] bindings. >> Only deviations are documented here. >> >> [1] Documentation/devicetree/bindings/mmc/mmc.txt >> [2] Documentation/devicetree/bindings/clock/clock-bindings.txt >> [3] >> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> [4] Documentation/devicetree/bindings/phy/phy-bindings.txt >> + [5] Documentation/devicetree/bindings/power/power_domain.txt >> >> Required Properties: >> - compatible: Compatibility string. One of: >> @@ -36,6 +38,8 @@ Optional Properties: >> - #clock-cells: If specified this should be the value <0>. With >> this property >> in place we will export a clock representing the Card Clock. >> This clock >> is expected to be consumed by our PHY. You must also specify >> + - power-domains: A phandle of and PM domain as specifier defined >> by bindings > > A phandle of what? That's a typo. > >> + of the power controller specified by phandle. >> >> Example: >> sdhci@e0100000 { > > It would be nice to add the example code. Okay, I will show a sample code in V2. Thanks, shawn. > >> > >