From: Stefan Schmidt <stefan@osg.samsung.com>
To: Ozgur Karatas <okaratas@member.fsf.org>, yishaih@mellanox.com
Cc: netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def
Date: Mon, 12 Dec 2016 12:19:48 +0100 [thread overview]
Message-ID: <080dc5cc-3d72-a5db-2f53-5c6ce74837b4@osg.samsung.com> (raw)
In-Reply-To: <811031481540339@web1j.yandex.ru>
Hello.
On 12/12/16 11:58, Ozgur Karatas wrote:
> Hello all,
> I think should be use to "WARN_ON" and checkpatch script give to error, I fixed and I think should don't use "BUG_ON".
> Regards,
>
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
I pointed you already before to the Documentation how to prepare a
commit subject and commit message. You just replied with that you are
new to contributing patches. That is all fine and many people are new
each release. Please take the time to read the provided and pointed out
docs.
If you keep ignoring such suggestions and docs I would think people will
keep ignoring your patches.
regards
Stefan Schmidt
next prev parent reply other threads:[~2016-12-12 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 10:58 Ozgur Karatas
2016-12-12 11:19 ` Stefan Schmidt [this message]
2016-12-12 11:32 ` [PATCH 1/1] Fixed to BUG_ON to WARN_ON Ozgur Karatas
2016-12-12 12:39 ` [PATCH 1/1] Fixed to BUG_ON to WARN_ON def Leon Romanovsky
2016-12-12 13:04 ` Ozgur Karatas
2016-12-12 18:18 ` Leon Romanovsky
2016-12-12 20:24 ` Ozgur Karatas
2016-12-14 12:58 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080dc5cc-3d72-a5db-2f53-5c6ce74837b4@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okaratas@member.fsf.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®