From: "Edwin Chiu 邱垂峰" <edwin.chiu@sunplus.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Edwin Chiu <edwinchiu0505tw@gmail.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021
Date: Tue, 28 Dec 2021 08:45:21 +0000 [thread overview]
Message-ID: <0812c44f777d4026b79df2e3698294be@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <20211220121050.rnd3o7d5cksqbqnk@bogus>
Hi Sudeep and Daniel:
Thanks your response.
My CPU is arm CA7 that is 32bits cpu.
If I directly used cpuidle-arm.c function with enable "Generic ARM/ARM64 CPU idle Driver",
the cpuidle driver mount fail with "unsupported enable-method property".
This is due to linux kernel no invoke CPUIDLE_METHOD_OF_DECLARE for arm 32bits cpu.
There have no define cpuidle_ops.init and cpuidle_ops.suspend function for arm 32bits cpu too.
So I create cpuidle-sunplus.c to execute my cpuidle function.
Please correct me if I got mistake.
邱垂峰 EdwinChiu
智能運算專案
T: +886-3-5786005 ext.2590
edwin.chiu@sunplus.com
300 新竹科學園區創新一路19號
> -----Original Message-----
> From: Sudeep Holla <sudeep.holla@arm.com>
> Sent: Monday, December 20, 2021 8:11 PM
> To: Edwin Chiu <edwinchiu0505tw@gmail.com>
> Cc: robh+dt@kernel.org; Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; rafael@kernel.org; Sudeep Holla <sudeep.holla@arm.com>;
> daniel.lezcano@linaro.org; linux-pm@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021
>
> On Mon, Dec 20, 2021 at 01:37:32PM +0800, Edwin Chiu wrote:
> > Create cpuidle driver for sunplus sp7021 chip
> >
>
> Based on the driver here, I couldn't understand why you can't make use of existing cpuidle-arm.c driver
>
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2021-12-28 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 5:37 [PATCH v2 0/2] Add cpuidle driver for Sunplus SP7021 Edwin Chiu
2021-12-20 5:37 ` [PATCH v2 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Edwin Chiu
2021-12-20 5:37 ` [PATCH v2 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021 Edwin Chiu
2021-12-20 12:10 ` Sudeep Holla
2021-12-28 8:45 ` Edwin Chiu 邱垂峰 [this message]
2021-12-20 9:38 ` [PATCH v2 0/2] Add cpuidle driver for Sunplus SP7021 Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0812c44f777d4026b79df2e3698294be@sphcmbx02.sunplus.com.tw \
--to=edwin.chiu@sunplus.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edwinchiu0505tw@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®