From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB94744839A for ; Tue, 14 Jul 2026 16:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784045598; cv=fail; b=kNW+cywGpqSpx4IJfRplrNC3vDBDN2tfdADNNjqQ27ofFjKFZ8AEX0Fko1UqIFs8zpgouCAQzFlvHIhOgIJ5s5MSt3Se6y4CaQBWprIpuL7aVFIo8eBpxfeBOexfLUEKFlRoAlh4h1a33ms9j9vvRpf0RwOOZAN4cQ2mjPI5bS4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784045598; c=relaxed/simple; bh=VT6ANLORmSVv3kONKPLfePOHAMFvbi3+a6Td8viCjkU=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=jZuhJUGJcDyoULC+7DGXH3usNApuRTpYWQnuJp/qRUAdKe90LMxXcuiJdBOj2W84i2hd20e8GTjOPOYii8OXkfrZ1lG5EK43KLO4YLNf30SGjAoNHZQmP5G+rYhC/FVPcdcqon6326g+kiyyFYQcU3nfYSK7LiwMW4zIyGBKVPI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T/a+ia5V; arc=fail smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T/a+ia5V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784045595; x=1815581595; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=VT6ANLORmSVv3kONKPLfePOHAMFvbi3+a6Td8viCjkU=; b=T/a+ia5VR6he7U/6tKdNMUopFsTIm6CRwPqWEJ/ZZ8Qw++nPEMuLg+mh JktgJ7zfCl2H7mJGLLI64QSY2RB20OQhRLWU+r2Lako0IisjbjuFzTzmy jWneb9OlOM202Nt8loQZHzxtmkGaZvZ4KpcmnVJFHFV52yTt5T8XblTtF TKxPwoZ8MX9l2yiwgGx6MBiAh/C3YB9k2AJKVUhm+DTqvgH3d56uyfAhk HxmsmFrQjonGi9kPqkgyvIz2M3lCDXZWI7feisoY4XfegzJnRBQYoZNiA 6Z/VUAeQnPh7uAePht8GvMA46MUfXXlpBBFErCpNC5lNIF5bhW4kQjEtn Q==; X-CSE-ConnectionGUID: YGfEfVPIR+SVf+JKRWC7jQ== X-CSE-MsgGUID: R+q1weWXTwG/rQo3AoXh8g== X-IronPort-AV: E=McAfee;i="6800,10657,11846"; a="88495302" X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="88495302" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 09:13:15 -0700 X-CSE-ConnectionGUID: tosMWqAGSNOin8zKpid61A== X-CSE-MsgGUID: AZ+xIOrFTbqqrsdEsqK5Ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="285974749" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 09:13:15 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 14 Jul 2026 09:13:14 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Tue, 14 Jul 2026 09:13:14 -0700 Received: from CO1PR03CU002.outbound.protection.outlook.com (52.101.46.59) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 14 Jul 2026 09:13:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P1J0UBEsD/G3qoTXxUtO1g7mvjk7j2vZF7NWyyI20t1t7JXEfiE5DQd++DT6dbll4qen/zqhjarnjkz80qK34HOGoXM4JSnFhnCphEoeu+Dj2PgI9ftfSnzdD5DSx4Dbm8RdzMhixQ1xP11TO+yq1i/KMb3qAteHlXYaHR3+QJq3C9EDkHubAfCB6JfDRkVdB19ATS9C8Lfej8cij/bKyCt9qoREjU1v/7DHe0dDtn08leMEyb7afPxYRud2CyFNdMCJ9hxDwiNSUsj7FdhpE1vdFnI7fufJDJ1yaA1EwQY1h3VYqOvpXSFhaP7TMxhrVXNMIcyF9LJrQ4KhpDZStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cUVq14jypdAIlzW0tofSu29erwvaqbFmoA4u8kX4dW0=; b=r1qgtvY//vTRPimlfYRlT3AzfUEl7UmtCnQ+5moQSdbci81BjKQJPt3WugpELUwzFdGQKHWLSDiBWE+FxXL7RHyen9qnFL3SWndAXt1P4VCOe4YZczfVlHXE47GTnS/ywaaXdyQ8wu/TXdCE9Zg+l0FNoThoxHMQreH23RsOXShgMw6H97oYSqKVTAe2zj29M9kCDF0oqajkct+yl6AtFTqSO29zMpa/vzEZBGtOIfvCYng3IN36X+0Db4tVOncET9cvtyPJyPeJYTSLC9OCHdiFrTFJxlZzOOOr/qFQPnC4YH6EAoOxLCam7uG4FYVQWxKjFOegilq5TsdZFgHNgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by CY5PR11MB6440.namprd11.prod.outlook.com (2603:10b6:930:33::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9; Tue, 14 Jul 2026 16:13:10 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0202.014; Tue, 14 Jul 2026 16:13:10 +0000 Message-ID: <0814ad58-8c3e-4e81-aadf-026c0b52f775@intel.com> Date: Tue, 14 Jul 2026 09:13:07 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/10] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains To: "Chen, Yu C" CC: , , , , , , , , , , , Hongyu Ning , References: <04bf985905dfaa759b919a11fd5d806b179fc0bb.1782866200.git.yu.c.chen@intel.com> <83182a45-e4e5-47df-88cd-79c0f6beaed1@intel.com> <113d3788-4388-4bf0-ad1f-d03232d770b6@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <113d3788-4388-4bf0-ad1f-d03232d770b6@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR03CA0256.namprd03.prod.outlook.com (2603:10b6:303:b4::21) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|CY5PR11MB6440:EE_ X-MS-Office365-Filtering-Correlation-Id: 0993b689-54cc-4490-a2ce-08dee1c2cc4a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|23010399003|56012099006|4143699003|11063799006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Exsrv8JLCHgsYUj+g8GnVRousgdvI1jjqplqLpLEFsWbaMEMpmyErBKF5n/FiXFWj/L/4lSqONTVV/OTjI5kz2LDNSPaahHJnopvCfMyAfLaoRq8xachl30ToXKNMjW+ITSL4Ug+gmh/B0wwcQ8ghadwSe60URuScng1BEjaY2SE1cV0ZtYpw9V+SHfsI5cVUJtfhvQLgrh9DhMXkSNp3ASNQpLWcZ9DJT2iLxthUX8sw7Ju8ifV7cORF1dSBUWFqbWGb0cpeITQGyJy65dmdncTK3OJ58VGh7qGiMEAqiJ9SQQz2pbobtYM4+wI1KBJnWYMuyiXjdAc66mbeqGmK4Fr7OthySyIjkn/Fy1qB7VqVny6vTTGNKUKlyn5ksLJSVtiJXo5bWrokaxkpKmT7bnemNIyDkWbYSG33IdqTFVsvAg1JCnPn4ZWMwa8qTh7GXmMt8Hlvz/tLhjUlK1lmD8ehgmimzLxx/ALDWWlSpp2CM8Wzqe5sWAzZh9kjTHwI81XmhVGNnCO0HaKmhg9M90reDXnNhalGmJrFl31Ns7xV9vxfnYjW1rDfQQoL91GwFcwHOk+umCX9Dxr9RXyCcEYwqHOorD7uy0U2Y/dXh9EOIondi7A0k3T7kM6Vnp0hJ66vCXNnM8gLVJ2aFyYqgWsoMTuK8pgYFohAFPdsdA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(23010399003)(56012099006)(4143699003)(11063799006)(3023799007)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1lPeFdrK2tyT2dxWjRzSGNSc1JTYzdCUUhUYTVTMGFqaHJUZ0kyWUdmdFZy?= =?utf-8?B?Y2dWUjJacythcGtkTlRKc1JWa3d3WDlwZ1BPZEdxSmo3UkZJQTlJT2lCYzRX?= =?utf-8?B?VVpzS21VMkNHajluMGFXVXlCWFhFTzd4dDlTRzY5QTZzS21tMmgxdG1XMnpZ?= =?utf-8?B?SGRDc2JPbUNuc3JFY3RhMWFLZnZsMkFwT2I5c0Z5VlBCNExZYjJWbndEYjd0?= =?utf-8?B?QzI1ZGJxdzI2aW5ReTdTdGI3eFJpZzI3OWVUYjJGNERQZDI1VHdLa2NYYjls?= =?utf-8?B?OXduUEJYL2FFYWt3Y1F3MjU1RGdMWXVwcXMxR0kyZFF3UEZUWk9JOVdvOUhE?= =?utf-8?B?T25SKzJiUUN0aFN5MjJWdnhtNTJmSVNMeUhFWHo1SkFlcnlJQU1yREgzNEJh?= =?utf-8?B?dVpkcHhrYUJhUy8yN2g3NUdJaFFNU21oOEQ2ZzhWYnQ2N1UrZGpEYVpsYUk3?= =?utf-8?B?dVF3MUtOeGpCQjlFYmlUam9kNG5BUDNycE9xM09LRWZQTVJ2U3gxYjBSZHJ5?= =?utf-8?B?dnZTZkhLYUQ4a0xoZkdkMVdPMEtFaGN5NGZZTUVsV2tocjlpamhzTkhhY2gv?= =?utf-8?B?V0ZCREJjMmY2UzFGQmFJTDY4TVk3aGI3MWwvZjZBck1kN1Fpa2xpQ3Q2VlZo?= =?utf-8?B?VlZySEJ3UWdBM3lRTkFGQW0vZXluUzlyWjBOMjJkQmJsa2JRcmxZSHJJa1hn?= =?utf-8?B?cTFGek5aZ0h0T20ybGtRdTQ0S2tDK0NkbCtSOFF3akhVMUEzdm9IQWNUTGdN?= =?utf-8?B?bDZJeHFlbnlwOWpLMElkaGJ3NWcyL3hvRnRkcXFQelJ1WExGaVdTUXlaVkEv?= =?utf-8?B?cUJXUlQwL2IzSGlnd2R0WXU1UjFCVUhPSFR0Wk9WVlpGTWRJYmJ0RmxHcXBZ?= =?utf-8?B?Nm9yQlBJZXdlSnZ6YTJNZDVPdTZiT1NBdkcyTXZ5OTVxUjcwVk5pUEVuREhW?= =?utf-8?B?cE1mS01lTEdSa1E3cmVxV3hMZm5JL2pocW1lNHNFUHp6bmh6Rkg1dFgwTS9E?= =?utf-8?B?dTk0M1JiaDI3d1lXMThrU1liVVRBdStLdC96K2tGVjdLNkZEeTh5aG4wU09k?= =?utf-8?B?cVZsS1ZmZHM2WHgwQTY4TzNCYXcyY1JWUGt3cjBaUWFPSkUyN3FrQTNGNHBm?= =?utf-8?B?RjBSNFExcHBuRm1JNEhLWWpPUXpGQzlKZ1ZTa2pieTBLNkp3d0d0ZWdyV1Q5?= =?utf-8?B?MmNQZFROMEdrWkdBTGpabzRHSVV0UktKTG9scElIY3pwVzl1RWxLY1VsMmdl?= =?utf-8?B?bE52OExRRkdyNTNVWlZOdDE5TWhib2RGQWJpd0k1cE9lbUVaeEpNcjJqU2J5?= =?utf-8?B?a1MrcDB5RmwrdG0rUlUxMk40blNqaFFja1ZiNks2VUloeG1ob0U0YklpYW9j?= =?utf-8?B?N3owQ0N5OHZSU05tRGFBUWJDRlVrc2N0Rm9OVStENStacjgrTTFvRE9yaXBL?= =?utf-8?B?QzJtazRzcEdUajdhT0FSdXBlUVNGcWVXalBsa2JSM0ZOK0hMVjBtWUswdnZw?= =?utf-8?B?MWhvaGpsV2ZQd0dWR2Y2bzFsRWYydmY4M3ZuTFFsUUFreGtDUGlrbzRQU2dQ?= =?utf-8?B?ZDJuREk2a0dNNVJRTWVBeC9DMzZybk5UQnhqWTdBYUtGTjdFZGp1OWRDaDJ4?= =?utf-8?B?RytCWEx5QzU3eHJwR1E1ZkFSSTVKN0h4M21TQnBmZDVHN1hOVTNUNUQ1cFhs?= =?utf-8?B?OUZjbjdxUityMVRKa2NVMkJGOHJ1VkJHWEdjb0k0UDdRd1lORGpDSkdxcXZL?= =?utf-8?B?T2x0aUlyckUrS25wVHFheEduQ0dLdXo5WXBKTWxzRDJBZ1BMczh1UkRxcm9i?= =?utf-8?B?bDFxUDJNM0tkaXRXN0RDNlcyNTA2TjJtRWZxUnd2V0c5ZzR4Ukh1SlEydGZa?= =?utf-8?B?UE0yMk4rUVhQRVdMTFpCeGNTZC91bWNwdzFHZTZZd3N0QThkTkQxNkFrdVFw?= =?utf-8?B?eEdVY3p2UDF4Ukp2dzNDS1ZJb3lJSS9jNDBadFkzYkxaS1pJeGFQZitFaytI?= =?utf-8?B?eWUvQTA5a0dXSHlEQjh5NHBOeFVjOFk1aWU3ditsZ2FMVlR3QVFaZDFUOEMz?= =?utf-8?B?R1Zmd3hkTFhuN0pXYW1JQkRQcWNYYzJ6dm5kWWY3OWplTDNyRzh5SUFRYUdm?= =?utf-8?B?VGZiQ25waEI3dzFibFpKaG5GWVExV0IxRUwrOUZPTlMrQlhBNHJWaEZQVUtO?= =?utf-8?B?WUppRlJybG10cG5tVnpUVWZOenRiT2tHbm5EaGw0VHdET0VtS0kyalA3ZHQ1?= =?utf-8?B?L0JGWWRweU1kd1pxKzNrbHpVVlQ5Zjd3SkVickkza0tOK1pOZzVnK3cvdTBW?= =?utf-8?B?UGZVaUJOMGdWRUNiUm9GYWJCLysyNFNlL3hMUzRWSE4zZlBWU0djM0d5a0dt?= =?utf-8?Q?DXEeVaCk0rm6eToc=3D?= X-Exchange-RoutingPolicyChecked: c/Ji6ASyz/i9JDwaPsbfPJPQDaXkX8JN/zHXwTnCSL87Y8/bo3T3G47d6SWE6Q1RkNuKpJVF2/dVPhpu3uQuXBjZq1vOrgBzvR0SGKM9VvZxOykUv4wb3OPWbi1DDZtbxtKcllSgSxhyRxWRX6QEM905xzXZAaXYHqJ1tk3UT5fdWlUuVGYWad+88FATdwILtPFLj0h/LOp55ZI7yYAwvZoatBMZzNHYtMXFXr1sKadj5+lf7AxlVpcJkl3TFb5G5LJiJSlj9Tu6puBwBFj4lCHPmbtc/PSzclhspijrlD0H3w1Qbjip4Ix1+XPpU1rBff9n2G9ijQTXELMj43oeIQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 0993b689-54cc-4490-a2ce-08dee1c2cc4a X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 16:13:10.2243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pyEsAfNxxPMwoJ47dxGfGtEYd2xDw7VnlC5lt9Q1z0YkIzYFUVZgRunVJYr8rVmYgH3reY7V4bWAqTu2EfLUZV0xysmX276aueH2Rs7rxvw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6440 X-OriginatorOrg: intel.com Hi Chenyu, On 7/14/26 8:19 AM, Chen, Yu C wrote: > Hi Chenyu, > > On 7/11/2026 7:42 AM, Reinette Chatre wrote: >> Hi Chenyu, >> >> On 7/1/26 6:45 AM, Chen Yu wrote: >>> From: Anil S Keshavamurthy >>> >>> Parse the ERDT (Enhanced RDT) ACPI table so enhanced RDT features can >>> consume firmware-provided domain information. >>> >>> The ERDT may contain these sub-tables: >>> >>>    - Resource Management Domain Description Structure (RMDD) >>>    - CPU Agent Collection Description Structure (CACD) >>>    - Cache Monitoring Registers for CPU Agents Description Structure >>>      (CMRC) >> >> How should "The ERDT may contain these sub-tables" be interpreted here? >> This sounds like some high level partial description of ERDT that is >> not specific to this patch. >> > > I planned to add some background context on ERDT. Let me remove unrelated > content and change the sentence to: > Parse the RMDD subtables within the ERDT ACPI table and their nested > CACD entries to construct per-domain CPU masks. Thank you. Making this patch specific will also help to identify unrelated changes, for example the introduction of ERDT_MMIO_CMRC_BASE that would be more appropriate for the patch that uses it. ... >>> + >>> +#include >>> + >>> +#include "internal.h" >>> + >>> +static LIST_HEAD(domain_info_list); >>> + >>> +static bool __erdt_enabled; >> >> Is double underscore needed? > > The double underscore was used to prevent name collisions with the > existing erdt_enabled(). Let me switch it to a single underscore instead. You say "existing" but I am not able to find erdt_enabled() in this series. Is it something that will be needed later? > >> Could you please add a comment above the variable to describe what it means when >> "erdt is enabled"? >> > > OK, let me add this: > > /* >  * Set when the ERDT ACPI table has been successfully parsed and at least >  * one valid RMDD domain with a CACD cpumask exists. Cleared on teardown. To make this easier to understand, please aim to have comments that do not describe code verbatim but instead what it means. Consider, for example, something like: "True when the ERDT ACPI table describes at least one domain with at least one CPU." >>> +        d = container_of(pos, struct erdt_domain_info, list); >>> +        list_del(pos); >>> +        cleanup_one_domain(d); >>> +    } >>> +    __erdt_enabled = false; >>> +    valid_subtbl_mask = 0; >>> +} >>> + >>> +static __init int enumerate_erdt_table(struct acpi_table_header *table_hdr) >>> +{ >>> +    struct acpi_table_erdt *erdt = (struct acpi_table_erdt *)table_hdr; >>> +    struct acpi_subtbl_hdr_16 *subtbl; >>> +    void *table_end; >>> + >>> +    if (erdt->header.revision != ERDT_VALID_VERSION) { >>> +        pr_info("Unsupported ERDT table revision %d\n", erdt->header.revision); >> >> Would it be helpful to print what the ERDT table revision is to help diagnostics? >> > > Yes, it will print the revision, do you mean print the expected revision? > > pr_info("Unsupported ERDT table revision %d (expected %d)\n", >         erdt->header.revision, ERDT_VALID_VERSION); oh, apologies, I misread what you had originally. Even so, your new proposal looks good to me. As a sidenote, please use most accurate conversion when printing, for example %u for unsigned instead of %d. Reinette