mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	rvaswani@nvidia.com, Brian Norris <briannorris@chromium.org>,
	dmitry.torokhov@gmail.com,
	Douglas Anderson <dianders@chromium.org>,
	acho@suse.com, Johan Hedberg <johan.hedberg@gmail.com>,
	Network Development <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Gustavo F. Padovan" <gustavo@padovan.org>
Subject: Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session
Date: Tue, 27 Jun 2017 19:32:52 +0200	[thread overview]
Message-ID: <0815411E-62D7-42DC-A0BF-78FD150C0949@holtmann.org> (raw)
In-Reply-To: <1498556084-25346-1-git-send-email-jeffy.chen@rock-chips.com>

Hi Jeffy,

> It looks like bnep_session has same pattern as the issue reported in
> old rfcomm:
> 
> 	while (1) {
> 		set_current_state(TASK_INTERRUPTIBLE);
> 		if (condition)
> 			break;
> 		// may call might_sleep here
> 		schedule();
> 	}
> 	__set_current_state(TASK_RUNNING);
> 
> Which fixed at:
> 	dfb2fae Bluetooth: Fix nested sleeps
> 
> So let's fix it at the same way, also follow the suggestion of:
> https://lwn.net/Articles/628628/
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: AL Yu-Chen Cho <acho@suse.com>
> ---
> 
> Changes in v4: None
> Changes in v2: None
> 
> net/bluetooth/bnep/core.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

all 3 patches have been applied to bluetooth-next tree.

Regards

Marcel

  parent reply	other threads:[~2017-06-27 17:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  9:34 Jeffy Chen
2017-06-27  9:34 ` [RESEND PATCH v4 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session Jeffy Chen
2017-06-27  9:34 ` [RESEND PATCH v4 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread Jeffy Chen
2017-06-27 17:32 ` Marcel Holtmann [this message]
2017-08-23  7:29   ` Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Jiri Slaby
2017-08-23 18:07     ` Stable apply request David Miller
2017-08-23 18:14     ` Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Marcel Holtmann
2017-08-27 13:10       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0815411E-62D7-42DC-A0BF-78FD150C0949@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=acho@suse.com \
    --cc=briannorris@chromium.org \
    --cc=davem@davemloft.net \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gustavo@padovan.org \
    --cc=jeffy.chen@rock-chips.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rvaswani@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®