From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932373AbdA0JPz (ORCPT ); Fri, 27 Jan 2017 04:15:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51198 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754777AbdA0JPe (ORCPT ); Fri, 27 Jan 2017 04:15:34 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EE5F360AA8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label To: Kishon Vijay Abraham I References: <1485504619-31886-1-git-send-email-vivek.gautam@codeaurora.org> <588B01BB.6050206@ti.com> Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Subhash Jadavani , "Martin K. Petersen" , stable@vger.kernel.org From: Vivek Gautam Message-ID: <081d5284-0ec5-c1b0-826b-a72d3c07c7dd@codeaurora.org> Date: Fri, 27 Jan 2017 14:34:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <588B01BB.6050206@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2017 01:45 PM, Kishon Vijay Abraham I wrote: > > On Friday 27 January 2017 01:40 PM, Vivek Gautam wrote: >> We want to skip only tx/rx_iface clocks and not ref_clk_src >> as well. Fix the jump label accordingly. >> >> Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy") > merged, thanks. Thanks Kishon. > > -Kishon >> Cc: Subhash Jadavani >> Cc: Martin K. Petersen >> Cc: Kishon Vijay Abraham I >> Cc: stable@vger.kernel.org >> Signed-off-by: Vivek Gautam >> --- >> >> Based on linux-phy next. >> >> drivers/phy/phy-qcom-ufs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c >> index c69568b8543d..1aee8723a682 100644 >> --- a/drivers/phy/phy-qcom-ufs.c >> +++ b/drivers/phy/phy-qcom-ufs.c >> @@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common) >> if (err) >> goto out; >> >> +skip_txrx_clk: >> err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src", >> &phy_common->ref_clk_src); >> if (err) >> goto out; >> >> -skip_txrx_clk: >> /* >> * "ref_clk_parent" is optional hence don't abort init if it's not >> * found. >> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project