From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757027AbcIPCKN (ORCPT ); Thu, 15 Sep 2016 22:10:13 -0400 Received: from mail-yb0-f177.google.com ([209.85.213.177]:35286 "EHLO mail-yb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbcIPCKF (ORCPT ); Thu, 15 Sep 2016 22:10:05 -0400 Subject: Re: [PATCH] staging: android ion/hisi: fix dependencies To: Arnd Bergmann , Sumit Semwal References: <20160915155751.3011135-1-arnd@arndb.de> Cc: Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Chen Feng , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: <08266540-f2ea-7e18-dc60-cca5ce880631@redhat.com> Date: Thu, 15 Sep 2016 19:10:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160915155751.3011135-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/15/2016 08:57 AM, Arnd Bergmann wrote: > The newly added Hi6220 Ion code fails to build when the ION_OF helpers > are not present: > > drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove': > hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to `ion_destroy_platform_data' > drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_probe': > hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to `ion_parse_dt' > hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to `ion_destroy_platform_data' > > This selects the symbol when needed. > Acked-by: Laura Abbott > Signed-off-by: Arnd Bergmann > Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform") > --- > drivers/staging/android/ion/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig > index 94105544feef..c8fb4134c55d 100644 > --- a/drivers/staging/android/ion/Kconfig > +++ b/drivers/staging/android/ion/Kconfig > @@ -36,6 +36,7 @@ config ION_TEGRA > config ION_HISI > tristate "Ion for Hisilicon" > depends on ARCH_HISI && ION > + select ION_OF > help > Choose this option if you wish to use ion on Hisilicon Platform. > >