From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D06ED36DA03 for ; Mon, 27 Jul 2026 11:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785151703; cv=none; b=llJRq+0dqnSbhGGwiYLMMEsF8Y/bSIYab8cgxcD6uBAB0RhS8fSkmfLBFWh/r3gRtSDMNTlXggXMYXMdcE1DYAwqjl/oG727Akroj3x5IwWn8Gp+Sk7IVmsrMryZA7MiSu3jLrVmGMEnKBY9chje0KiZP5F17JksTqDU/6Wibgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785151703; c=relaxed/simple; bh=09TzpNPlpAsbUwKktH4LwOhGx+HC45prlMax6dBjupE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S7VTKQRNc3qGRM6DCEc0HhzlCSowzq95POK9XFPZRDo5UisNvjnXRXDYXcz3tkN2fdDmorhuLZX+bdwtO3pCOm87RMS8PyvxYWqOf4avwdbbqv5+Jn5BBwNGHoy39y6AkBlIEnhn0q6z+ZBI3YYwwPKk1ZOzzYWqgr0jQczMUzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eKqRH4NT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eKqRH4NT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 727171F000E9; Mon, 27 Jul 2026 11:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785151701; bh=ypFQw1CeirYBGnemI2krStfLmBxeWvPIPB5r9QbhoHs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=eKqRH4NTPp4uk0wDFAgkBcwxsQvEBNkfvK2iig6Db/fVj+Qgprf8RHGAabew9xhUD hbC1ZztfdCeo9OD1eZ0ihg0kJtS/JZEYuytEXn3Vl7UgdMesqnBD+CL+woORvUbfQB De+z4OabxPLSAbCrbF9NNUybqYt6pm9EXt/ZYLYWtlMHZG3bUj9WLFla7oBOxVPSjm l8LDHkJjKP5Q2RbbgbCVZoBVx0+4b6mek0Q2Xet34FCMEuzVKxihQfIIJMZcza67Yo CvbTLS8fZytQmAHWrOqR0tKtIKrNcxHo6s6YGREaqn8chXy+QpoeqpRo6YiM9u0DGT bFtFbAt590NBg== Message-ID: <0829b0c0-9b33-4f29-8f10-1b85b828bc8a@kernel.org> Date: Mon, 27 Jul 2026 13:28:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] sched: dynamic: Simplify irqentry_exit_cond_resched() To: Mark Rutland , Shrikanth Hegde Cc: linux-kernel@vger.kernel.org, frederic@kernel.org, jstultz@google.com, juri.lelli@redhat.com, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, vincent.guittot@linaro.org, vschneid@redhat.com References: <20260703133358.698078-1-mark.rutland@arm.com> <20260703133358.698078-5-mark.rutland@arm.com> <4905f97c-9154-4794-b337-808f6eec2949@linux.ibm.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mark, Le 17/07/2026 à 13:05, Mark Rutland a écrit : > On Mon, Jul 06, 2026 at 10:12:29AM +0530, Shrikanth Hegde wrote: >> +cc Christophe. >> >> On 7/3/26 7:03 PM, Mark Rutland wrote: >>> PREEMPT_DYNAMIC is now limited to the FULL and LAZY preemption models. >>> In either model, irqentry_exit_cond_resched() is always called and never >>> disabled. >>> >>> Remove the unnecessary code for this when PREEMPT_DYNAMIC is selected. >>> >>> Signed-off-by: Mark Rutland >>> Cc: Frederic Weisbecker >>> Cc: Ingo Molnar >>> Cc: John Stultz >>> Cc: Juri Lelli >>> Cc: Peter Zijlstra >>> Cc: Thomas Gleixner >>> Cc: Valentin Schneider >>> Cc: Vincent Guittot >>> --- >>> arch/powerpc/include/asm/preempt.h | 7 ------- >>> include/linux/irq-entry-common.h | 17 +---------------- >>> kernel/entry/common.c | 17 ++--------------- >>> kernel/sched/core.c | 7 ------- >>> 4 files changed, 3 insertions(+), 45 deletions(-) >>> >>> diff --git a/arch/powerpc/include/asm/preempt.h b/arch/powerpc/include/asm/preempt.h >>> index 000e2b9681f30..79fc1f9df88d9 100644 >>> --- a/arch/powerpc/include/asm/preempt.h >>> +++ b/arch/powerpc/include/asm/preempt.h >>> @@ -4,13 +4,6 @@ >>> #include >>> -#if defined(CONFIG_PREEMPT_DYNAMIC) >>> -#include >>> -DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); >>> -#define need_irq_preemption() \ >>> - (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) >>> -#else >>> #define need_irq_preemption() (IS_ENABLED(CONFIG_PREEMPTION)) >>> -#endif >> >> JFYI, >> Christophe had sent this patch, I am sure you guys will sort out the >> conflicts. (I don't see it merged yet, but likely might) >> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F2bf10a0afffefb6aca44bf2f864cc17471a80e31.1781870889.git.chleroy%40kernel.org%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7Cd53a0ccd869f471aaafe08dee3f345aa%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639198831155344265%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Uz61UVryN4sw1GprTddsVCFvEkuXguHZufVNJr0PpeY%3D&reserved=0 > > Thanks for the heads-up! > > Sorry, I'd skipped Ccing all the arch folk as I hadn't expected anyone > was likely to be doing similar in the arch code right now. I'll make > sure you're both Cc'd for any subsequent versions. > > It looks like the only difference for powerpc is that I leave > need_irq_preemption() lying around. Christophe, if you're happy with > this series, I could pick a patch from you to remove that (e.g. take > your patch and apply it to the end of this series, reduced to removing > need_irq_preemption()). > > Any preference? I'm just back from summer vacation. No preference, but it looks like my patch was merged into v7.2-rc4 as commit a2c02aa0c6ca ("powerpc: Remove dead non-preemption code"), so I fear you'll need to rebase your work on top of it. Christophe > > [...] > >> Change per se, looks good to me. >> >> Reviewed-by: Shrikanth Hegde > > Thanks! > > Mark.