From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444AbcHPK4B (ORCPT ); Tue, 16 Aug 2016 06:56:01 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:42768 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbcHPKz7 (ORCPT ); Tue, 16 Aug 2016 06:55:59 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 addr_info_check: 0 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: nicolas.ferre@atmel.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM To: Krzysztof Kozlowski , sre@kernel.org References: <1470996110-8550-1-git-send-email-andy.yan@rock-chips.com> Cc: matthias.bgg@gmail.com, dbaryshkov@gmail.com, richard@nod.at, alexandre.belloni@free-electrons.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, nicolas.ferre@atmel.com From: Andy Yan Message-ID: <082e9630-26cb-6587-6f9f-f97c334407ca@rock-chips.com> Date: Tue, 16 Aug 2016 18:55:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian: On 2016年08月12日 20:48, Krzysztof Kozlowski wrote: > On 08/12/2016 12:01 PM, Andy Yan wrote: >> commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from >> syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so >> let's depend on MFD_SYSCON instead of selecting it directly to avoid the >> um-allyesconfig like build error on archs that without iomem: >> >> drivers/mfd/syscon.c: In function 'of_syscon_register': >> drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] >> base = ioremap(res.start, resource_size(&res)); >> ^ >> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion] >> base = ioremap(res.start, resource_size(&res)); >> ^ >> drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] >> iounmap(base); >> ^ >> >> Reported-by: Kbuild test robot >> Fixes: 4fcd504edbf7("power: reset: add reboot mode driver") >> Signed-off-by: Andy Yan >> >> --- >> >> Changes in v1: >> - let this driver depend on MFD_SYSCON >> - add Reported-by tag, which suggested by Krzysztof Kozlowski >> - add Fixes tag, which suggested by Matthias Brugger >> >> drivers/power/reset/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > > > Will you please take this patch to avoid the Kbuild test robot warning ? Thanks