From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B35C27735; Sun, 16 Feb 2025 16:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739724570; cv=none; b=ES25c22/4b9Fjm4vOYaqHFI9DEZ9mA+4woJnBwIyiqPj4/4HbEIJXnr96s87J2hGqRTVetEqLUDBN14d2fTsZznCUa+mpEFZ17kNdoyez8fL9io0mjQsHWLy+FRyBUq6vKH4QF1peWBwnClKh6UK2adVINHxkz3OzcdLk9h7Jp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739724570; c=relaxed/simple; bh=m1dKwdDO2q8mLEjpw+cxaly+MNJTeCcOnCeCU7XoTco=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D2jIJmSpCredx7rd8aiR6HjbkvPpoY02G1vAHIqDSkJuZbW3l5hw5zVd0W/4nXT2zHV5Ktkoh/b9yo57h4em0YwuJ7ywdxE2ay/w65ZHbByScoZndfnuhWp+t2uhDHkJu/kcC855JB3GzVll8deEgG21fSY8jljxF4qtwRiklps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=E4mMZ4LT; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="E4mMZ4LT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iZqorBL9NC50sKW8xRpM5vQTORnlBE5flNUJrgysfng=; b=E4mMZ4LTDwAdjflnhCdA8uC2f4 rkJmaJNQ7qWcJgtQ1rog2qM54zWWe8DM577XKEG7XRhuiMvdvBWNTAThh09Nsh125TkiGb61qecot Oy7FpDw2FJVSG2H4qx+F3n70XrAbTYNMztDm/0wn/wf5RbC1aTa7sjg4rNq4t6/K28nM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tjhpW-00EhmQ-N6; Sun, 16 Feb 2025 17:49:18 +0100 Date: Sun, 16 Feb 2025 17:49:18 +0100 From: Andrew Lunn To: Sky Huang Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , Simon Horman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Steven Liu Subject: Re: [PATCH net-next v2 4/5] net: phy: mediatek: Add token ring clear bit operation support Message-ID: <082f3095-d83f-47b6-b902-2d99482855b7@lunn.ch> References: <20250213080553.921434-1-SkyLake.Huang@mediatek.com> <20250213080553.921434-5-SkyLake.Huang@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250213080553.921434-5-SkyLake.Huang@mediatek.com> On Thu, Feb 13, 2025 at 04:05:52PM +0800, Sky Huang wrote: > From: Sky Huang > > Similar to __mtk_tr_set_bits() support. Previously in mtk-ge-soc.c, > we clear some register bits via token ring, which were also implemented > in three __phy_write(). Now we can do the same thing via > __mtk_tr_clr_bits() helper. > > Signed-off-by: Sky Huang Reviewed-by: Andrew Lunn Andrew