From: Hayes Wang <hayeswang@realtek.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 1/2] r8169: fix the default setting of rx vlan
Date: Mon, 15 Sep 2014 03:22:54 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2523183@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <20140912194014.GA15496@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
> Sent: Saturday, September 13, 2014 3:40 AM
[...]
> The same fix should be relevant for NETIF_F_RXCSUM. You may thus as
> well remove the "changed" test in __rtl8169_set_features and keep
> everything there.
In the probe function (rtl_init_one), RxChkSum has been assgined to
tp->cp_cmd, so only the vlan setting is incorrect. Therefore, I fix
it only. Do I still have to remove the "changed" test?
Best Regards,
Hayes
next prev parent reply other threads:[~2014-09-15 3:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 3:35 [PATCH net 0/2] r8169: fix " Hayes Wang
2014-09-12 3:35 ` [PATCH net 1/2] r8169: fix the default setting of " Hayes Wang
2014-09-12 19:40 ` Francois Romieu
2014-09-15 3:22 ` Hayes Wang [this message]
2014-09-16 0:03 ` Francois Romieu
2014-09-16 3:23 ` Hayes Wang
2014-09-16 3:40 ` [PATCH net] r8169: adjust __rtl8169_set_features Hayes Wang
2014-09-16 19:56 ` David Miller
2014-09-12 3:35 ` [PATCH net 2/2] r8169: fix setting rx vlan Hayes Wang
2014-09-13 20:53 ` [PATCH net 0/2] r8169: fix " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2523183@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®