mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next 2/2] r8152: adjust rtl_start_rx
Date: Fri, 14 Nov 2014 05:14:36 +0000	[thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2ED1624@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <20141113.162240.1823683928052355016.davem@davemloft.net>

David Miller [mailto:davem@davemloft.net] 
> Sent: Friday, November 14, 2014 5:23 AM
[...]
> What if even the first r8152_submit_rx() fails?  What ever will cause
> any of these retries to trigger at all?

According to the patch #1 "adjust r8152_submit_rx", the
r8152_submit_rx() would add the rx to the list and schedule
the tasklet, when the error occurs. Each time the tasklet is
called, the rx_bottom() would deal with all the rx in the
list. If the actual_length isn't vaild, the rx buffer would be
submitted directly. By this way, the retries would be done.
That is, the retries would be triggered when the tasklet
is called. Therefore, any tx, rx, and tasklet scheduling
would result in the retries.

> Second, why does your patch increment 'i' with 'i++;' in the error
> break path?  You should mark the first failed entry as unallocated
> with actual_length == 0 and place it on the rx_done queue.

Because the r8152_submit_rx() would add the failed rx to
the list, I only have to deal with the remaining ones. That
is why I increase the "i", otherwise the failed one would
be added twice.

I remember the usb_submit_urb() would set actual_length
to 0, so I skip the step. I would check it again.
 
Best Regards,
Hayes

  reply	other threads:[~2014-11-14  5:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07  9:55 [PATCH net-next 0/2] r8152: adjust rx functions Hayes Wang
2014-11-07  9:55 ` [PATCH net-next 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-07  9:55 ` [PATCH net-next 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-07 16:35   ` David Miller
2014-11-10  3:29     ` Hayes Wang
2014-11-12  2:50       ` David Miller
2014-11-12  5:07         ` Hayes Wang
2014-11-12  5:13           ` David Miller
2014-11-12  5:23             ` Hayes Wang
2014-11-12  5:43               ` David Miller
2014-11-12  6:29                 ` Hayes Wang
2014-11-12 19:49                   ` David Miller
2014-11-13  2:31                     ` Hayes Wang
2014-11-13  3:31                       ` David Miller
2014-11-13 21:22                         ` David Miller
2014-11-14  5:14                           ` Hayes Wang [this message]
2014-11-12  1:45     ` Hayes Wang
2014-11-12  2:19       ` David Miller
2014-11-12  2:30         ` Hayes Wang
2014-11-19  5:20 ` [PATCH net-next v2 0/2] r8152: adjust rx functions Hayes Wang
2014-11-19  5:20   ` [PATCH net-next v2 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-19 14:02     ` Sergei Shtylyov
2014-11-19  5:20   ` [PATCH net-next v2 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-20  2:29 ` [PATCH net-next v3 0/2] r8152: adjust rx functions Hayes Wang
2014-11-20  2:29   ` [PATCH net-next v3 1/2] r8152: adjust r8152_submit_rx Hayes Wang
2014-11-20  2:29   ` [PATCH net-next v3 2/2] r8152: adjust rtl_start_rx Hayes Wang
2014-11-21 19:53   ` [PATCH net-next v3 0/2] r8152: adjust rx functions David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0835B3720019904CB8F7AA43166CEEB2ED1624@RTITMBSV03.realtek.com.tw \
    --to=hayeswang@realtek.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®