From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933975AbbG1K3W (ORCPT ); Tue, 28 Jul 2015 06:29:22 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:35368 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbbG1K3P (ORCPT ); Tue, 28 Jul 2015 06:29:15 -0400 X-SpamFilter-By: BOX Solutions SpamTrap 5.54 with qID t6S9qEIY021284, This message is accepted by code: ctloc85258 From: Hayes Wang To: Oliver Neukum CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net 1/2] r8152: add pre_reset and post_reset Thread-Topic: [PATCH net 1/2] r8152: add pre_reset and post_reset Thread-Index: AQHQyQfrTaCLRAxAAk+2x4Apo5zMd53wDVoAgACUi3A= Date: Tue, 28 Jul 2015 09:52:15 +0000 X-BOX-Message-Id: t6S9qEIY021284 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F3C3EC@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-156-Taiwan-albertk@realtek.com> <1394712342-15778-157-Taiwan-albertk@realtek.com> <1438073562.11934.2.camel@suse.com> In-Reply-To: <1438073562.11934.2.camel@suse.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.71.143] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6SATS6J016796 Oliver Neukum [mailto:oneukum@suse.com] > Sent: Tuesday, July 28, 2015 4:53 PM [...] > > + return 0; > > + > > + netdev = tp->netdev; > > + if (!netif_running(netdev)) > > + return 0; > > + > > + ret = usb_autopm_get_interface(intf); > > + if (ret < 0) > > + return ret; > > What sense does this make? > [...] > > + return 0; > > + > > + netdev = tp->netdev; > > + if (!netif_running(netdev)) > > + return 0; > > + > > + ret = usb_autopm_get_interface(intf); > > The device will be awake. I don't sure if the device would be in runtimesuspend, so I wake it up by myself. I think you mean I don't have to do this. I would remove them and resend the patch. Thanks. Best Regards, Hayes {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I