From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbcFBGPy (ORCPT ); Thu, 2 Jun 2016 02:15:54 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:46690 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbcFBGPv convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2016 02:15:51 -0400 X-Greylist: delayed 305 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Jun 2016 02:15:50 EDT X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID u526ARkS028126, This message is accepted by code: ctloc85258 From: Hayes Wang To: Mario Limonciello CC: LKML , Netdev , Linux USB , "pali.rohar@gmail.com" , "anthony.wong@canonical.com" Subject: RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Topic: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Index: AQHRvE+yfb+dwBfgP0aQ9TPqgAmes5/VroKA Date: Thu, 2 Jun 2016 06:10:26 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2FECCF4@RTITMBSV03.realtek.com.tw> References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> In-Reply-To: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.128] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mario Limonciello [mailto:mario_limonciello@dell.com] [...] > static int set_ethernet_addr(struct r8152 *tp) > { > struct net_device *dev = tp->netdev; > @@ -1041,6 +1075,9 @@ static int set_ethernet_addr(struct r8152 *tp) > else > ret = pla_ocp_read(tp, PLA_BACKUP, 8, sa.sa_data); > > + /* if system provides auxiliary MAC address */ > + set_auxiliary_addr(&sa); > + > if (ret < 0) { > netif_err(tp, probe, dev, "Get ether addr fail\n"); > } else if (!is_valid_ether_addr(sa.sa_data)) { When tp->version == RTL_VER_01, you would have different MAC address between SW and HW. You may use the MAC address from ACPI for dev_addr. However, the device uses another one, because you don't set it to the device. Best Regards, Hayes