From: Hayes Wang <hayeswang@realtek.com>
To: "Mario_Limonciello@Dell.com" <Mario_Limonciello@Dell.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"pali.rohar@gmail.com" <pali.rohar@gmail.com>,
"anthony.wong@canonical.com" <anthony.wong@canonical.com>
Subject: RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address
Date: Fri, 3 Jun 2016 09:23:29 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2FED973@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <5a22a497af9e467582221cd3a10c90ff@ausx13mpc124.AMER.DELL.COM>
Mario_Limonciello@Dell.com [mailto:Mario_Limonciello@Dell.com]
> Sent: Friday, June 03, 2016 12:58 AM
[...]
> > Why generate a random one and not just use the one that the network
> > controler already provides?
>
> That's how the flow works in r8152 already and I'm not overriding it.
> Again, I'll send V2 and you'll see what I did.
The original flows are
1. Read MAC address 1 from device.
2. Check if the MAC address 1 is valid.
3. Use random MAC address if MAC address 1 is invalid.
However, your flow would be
1. Read MAC address 1 from device.
2. Read MAC address 2 from ACPI.
3. Check if the MAC address 2 is valid.
4. Use random MAC address if MAC address 2 is invalid.
Although MAC address 2 may be invalid, MAC address 1 may be valid.
For this situation, you have to use MAC address 1, not random one.
Best Regards,
Hayes
next prev parent reply other threads:[~2016-06-03 9:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 21:50 Mario Limonciello
2016-06-01 22:27 ` Andrew Lunn
2016-06-01 22:31 ` Mario_Limonciello
2016-06-01 23:06 ` Greg KH
2016-06-02 1:54 ` Mario_Limonciello
2016-06-01 23:05 ` Greg KH
2016-06-02 2:10 ` Mario_Limonciello
2016-06-02 15:22 ` Greg KH
2016-06-02 15:46 ` Mario_Limonciello
2016-06-02 16:09 ` Greg KH
2016-06-02 16:58 ` Mario_Limonciello
2016-06-03 9:23 ` Hayes Wang [this message]
2016-06-03 14:52 ` Mario_Limonciello
2016-06-02 18:04 ` Bjørn Mork
2016-06-02 18:28 ` Mario_Limonciello
2016-06-02 19:03 ` Pali Rohár
2016-06-02 19:18 ` Mario_Limonciello
2016-06-02 18:44 ` Pali Rohár
2016-06-02 2:53 ` Mario_Limonciello
2016-06-02 8:11 ` Bjørn Mork
2016-06-02 14:29 ` Mario_Limonciello
2016-06-02 7:27 ` Bjørn Mork
2016-06-02 6:10 ` Hayes Wang
2016-06-02 7:46 ` Pali Rohár
2016-06-02 14:45 ` Mario_Limonciello
2016-06-02 15:01 ` Andrew Lunn
2016-06-02 15:07 ` Mario_Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2FED973@RTITMBSV03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=Mario_Limonciello@Dell.com \
--cc=anthony.wong@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®