From: Dan Carpenter <dan.carpenter@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wang Ming <machel@vivo.com>,
kernel-janitors@vger.kernel.org,
Dinh Nguyen <dinguyen@kernel.org>,
opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool()
Date: Thu, 6 Jul 2023 11:28:25 +0300 [thread overview]
Message-ID: <083cfb82-84cd-417d-b5ac-2b831b24710e@kadam.mountain> (raw)
In-Reply-To: <fe780326-2150-a3e6-e451-ea82be65e0cf@web.de>
On Wed, Jul 05, 2023 at 08:21:02PM +0200, Markus Elfring wrote:
> Please apply a more appropriate patch subject.
>
Markus, a number of people have asked you to stop with this nonsense.
>
> > The devm_memremap() function returns error pointers.
> > It never returns NULL. Fix the check.
>
> Would the following wording be helpful?
>
>
> Replace a null pointer check by an error pointer check after a call
> of the function “devm_memremap” in this function implementation.
No. The original was fine. The original commit message is more clear
than your proposed commit message.
regards,
dan carpenter
next prev parent reply other threads:[~2023-07-06 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 8:26 [PATCH v1] firmware:Fix an NULL vs IS_ERR() bug in probe Wang Ming
[not found] ` <fe780326-2150-a3e6-e451-ea82be65e0cf@web.de>
2023-07-06 8:28 ` Dan Carpenter [this message]
[not found] ` <daa12e00-1d01-45d0-89c8-03ff94fa3399@kadam.mountain>
[not found] ` <SG2PR06MB3743AC289C8C124CA57C77DABD2CA@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-06 8:52 ` 回复: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory_pool() Dan Carpenter
[not found] ` <SG2PR06MB3743DD3C50017612CF3BE38ABD2CA@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-06 15:18 ` 回复: " Dinh Nguyen
[not found] ` <SG2PR06MB3743994BB1C786B2BE4A24A7BD34A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-14 14:44 ` 回复: " Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083cfb82-84cd-417d-b5ac-2b831b24710e@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=dinguyen@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®