From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Leitner <richard.leitner@linux.dev>,
Conor Dooley <conor@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: hwmon: ti,ina238: add ti,ina237
Date: Wed, 25 Oct 2023 16:22:27 +0200 [thread overview]
Message-ID: <0844080c-7524-4686-9df6-ba25e3f6b808@linaro.org> (raw)
In-Reply-To: <pwfj54krrau3rihjb73dd4p3yizzjyuv4gwxky776m2goerjw6@6rfxo6kzjhjs>
On 25/10/2023 16:13, Richard Leitner wrote:
> On Wed, Oct 25, 2023 at 02:58:44PM +0100, Conor Dooley wrote:
>> On Wed, Oct 25, 2023 at 10:34:14AM +0000, Richard Leitner wrote:
>>> Add ti,ina237 binding to ti,ina238 as they share the same driver.
>>>
>>> Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
>>> ---
>>> Documentation/devicetree/bindings/hwmon/ti,ina238.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
>>> index aba89e5f34b3..17408076696c 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
>>> @@ -22,6 +22,7 @@ description: |
>>> properties:
>>> compatible:
>>> enum:
>>> + - ti,ina237
>>
>> The driver patch you have done implies no difference between the
>> programming model for both of these devices. It'd seem to make more sense
>> for the ina237 to fall back to the ina238, thereby requiring no change in
>> the driver to support it.
>
> Thanks for the quick feedback, Conor.
>
> I first thought of just mentioning the ina237 in the documentation as
> "compatible" to the ina238. But IMHO it is better understandable if it's
> listed as compatible.
Conor did not oppose listing it. The point is to use fall-back.
>
> And I would strongly encourage mentioning it somewhere (documentation or
> compatible). So other people using the ina237 are able to find it and
> don't have to compare the datasheets by themselves to find the right
> driver.
Sure, there is plenty of space in the driver code (.c or Kconfig) to
document whatever you wish. We focus here on the bindings, though.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-25 14:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:34 [PATCH 0/4] hwmon: add ti,ina237 support to ina238 driver Richard Leitner
2023-10-25 10:34 ` [PATCH 1/4] MAINTAINERS: Add entry for " Richard Leitner
2023-10-26 1:03 ` Guenter Roeck
2023-10-26 6:46 ` Richard Leitner
2023-10-25 10:34 ` [PATCH 2/4] dt-bindings: hwmon: add ti,ina238 Richard Leitner
2023-10-25 14:00 ` Conor Dooley
2023-10-25 14:07 ` Richard Leitner
2023-10-25 14:11 ` Conor Dooley
2023-10-25 14:18 ` Krzysztof Kozlowski
2023-10-25 14:23 ` Richard Leitner
2023-10-25 14:27 ` Krzysztof Kozlowski
2023-10-25 14:32 ` Richard Leitner
2023-10-25 15:26 ` Krzysztof Kozlowski
2023-10-25 14:25 ` Conor Dooley
2023-10-25 14:28 ` Krzysztof Kozlowski
2023-10-25 10:34 ` [PATCH 3/4] hwmon: ina238: add ina237 support Richard Leitner
2023-10-25 10:34 ` [PATCH 4/4] dt-bindings: hwmon: ti,ina238: add ti,ina237 Richard Leitner
2023-10-25 13:58 ` Conor Dooley
2023-10-25 14:13 ` Richard Leitner
2023-10-25 14:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0844080c-7524-4686-9df6-ba25e3f6b808@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=richard.leitner@linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®