mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Matt Mullins <mmullins@fb.com>, Andrew Hall <hall@fb.com>,
	"ast@kernel.org" <ast@kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	Martin Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	"David S. Miller" <davem@davemloft.net>,
	Shuah Khan <shuah@kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH bpf-next v4 5/5] selftests: bpf: test writable buffers in raw tps
Date: Wed, 24 Apr 2019 22:56:56 +0000	[thread overview]
Message-ID: <0844db66-24e8-aaf8-9b86-467417f40241@fb.com> (raw)
In-Reply-To: <20190424190721.24453-6-mmullins@fb.com>



On 4/24/19 12:07 PM, Matt Mullins wrote:
> This tests that:
>    * a BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE cannot be attached if it
>      uses either:
>      * a variable offset to the tracepoint buffer, or
>      * an offset beyond the size of the tracepoint buffer
>    * a tracer can modify the buffer provided when attached to a writable
>      tracepoint in bpf_prog_test_run
> 
> Signed-off-by: Matt Mullins <mmullins@fb.com>

Acked-by: Yonghong Song <yhs@fb.com>

BTW, your patches have some conflicts with latest bpf-next, you may want
to rebase and resubmit.

      reply	other threads:[~2019-04-24 22:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 19:07 [PATCH bpf-next v4 0/5] writable contexts for bpf raw tracepoints Matt Mullins
2019-04-24 19:07 ` [PATCH bpf-next v4 1/5] bpf: add writable context for " Matt Mullins
2019-04-24 22:37   ` Yonghong Song
2019-04-24 19:07 ` [PATCH bpf-next v4 2/5] nbd: trace sending nbd requests Matt Mullins
2019-04-24 19:07 ` [PATCH bpf-next v4 3/5] nbd: add tracepoints for send/receive timing Matt Mullins
2019-04-24 19:07 ` [PATCH bpf-next v4 4/5] tools: sync bpf.h Matt Mullins
2019-04-24 22:38   ` Yonghong Song
2019-04-24 19:07 ` [PATCH bpf-next v4 5/5] selftests: bpf: test writable buffers in raw tps Matt Mullins
2019-04-24 22:56   ` Yonghong Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0844db66-24e8-aaf8-9b86-467417f40241@fb.com \
    --to=yhs@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hall@fb.com \
    --cc=kafai@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mmullins@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®