From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B899C433DF for ; Wed, 14 Oct 2020 06:58:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1068D2222C for ; Wed, 14 Oct 2020 06:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727717AbgJNG6l (ORCPT ); Wed, 14 Oct 2020 02:58:41 -0400 Received: from smtprelay0054.hostedemail.com ([216.40.44.54]:58456 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725977AbgJNG6k (ORCPT ); Wed, 14 Oct 2020 02:58:40 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 0A69518224D82; Wed, 14 Oct 2020 06:58:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bee95_1108f8c27209 X-Filterd-Recvd-Size: 2644 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Oct 2020 06:58:39 +0000 (UTC) Message-ID: <084a2dabe5463a3528bb052515555f939235c012.camel@perches.com> Subject: Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS From: Joe Perches To: Lukas Bulwahn Cc: Ujjwal Kumar , linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Tue, 13 Oct 2020 23:58:37 -0700 In-Reply-To: References: <20201013120129.1304101-1-ujjwalkumar0501@gmail.com> <316d5a53351d10cd1a26ce0c54883da05642c898.camel@perches.com> <04325089b524f20d3de167051bfb81b05083d8b1.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote: > > On Tue, 13 Oct 2020, Joe Perches wrote: > > > On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote: > > > On Tue, 13 Oct 2020, Joe Perches wrote: > > > > > > > On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote: > > > > > What does checkpatch.pl warn about and what does clang-format still warn > > > > > about, which is generally accepted okay as style in the kernel? > > > > > > > > clang-format doesn't warn at all, it just reformats. > > > > > > > You can run clang-format with --dry-run and then it would just state the > > > proposed changes, right? > > > > clang-format through at least version 10 does not have > > a --dry-run option. > > > > > > Just a quick check: > > version 9 does not have the --dry-run option: > > https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormat.html > > version 10 does: > > https://releases.llvm.org/10.0.0/tools/clang/docs/ClangFormat.html Perhaps some version 10 variants do, but 10.0.0 does not. $ which clang-format /usr/local/bin/clang-format $ clang-format --version clang-format version 10.0.0 (git://github.com/llvm/llvm-project.git 305b961f64b75e73110e309341535f6d5a48ed72) $ clang-format --dry-run clang-format: Unknown command line argument '--dry-run'. Try: 'clang-format --help' clang-format: Did you mean ' --debug'?