From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DA535AC01 for ; Mon, 13 Jul 2026 20:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783975644; cv=none; b=vAaFE3+eBYpdkbhb7dY4/mpAO+oCDTVXB6zNzAQGHM64vtqSDAoU5dro7LEYiaAK4ucsPNma6u7Oph9d24pDfUt5H2BJTSIDvIENI9bFsFrjJakevU4R1Zv0KDKYaOjZMcin4utF/rp8JO69Z8RafTYCogI5Z5RtOPC3vLCH2Dk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783975644; c=relaxed/simple; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=X0Pww3Pd7oyaFauUwpWpFrl7bylIGdzZ3WunwI3e5rZ6iKMfCCx78V3qRKCfHkPDRJyM1Q5rUUfFz9ejcWAvNPIZ1yD+5GPz+0x2fjZ6MbNBQwmdUvCb8e1tgX3P5lAOsCqwEFC1FJlkbisN1cU30nfxuo6crGySxGi6tYQkpEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kgPFK9P+; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kgPFK9P+" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-84a2dcec51cso1819846b3a.3 for ; Mon, 13 Jul 2026 13:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783975643; x=1784580443; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; b=kgPFK9P+xZkg3yKM2nqWJatyNEpv8NmsYeKomGm7nPnAxC9LFSEAr3SwbVhA9UlqSw 7oPYzN16QFZzK5BbEjQBFVACSk60Yf2de2G0F2n2pez/7vaxgfDhYzTaMrl58MpM0s99 kzh05ugi65oJbz5uunb4rhph78691DLbc4OOpCzCSVQQ7XJtfFiviq/VrlHyz4mNDjhg 7lSkYXNgr9vvoAbyPgEuJsE6IGAcND2h5E9A/yZ6zwEqLxtb/3QIoElrlBeTgQWMzJey k9pGgJha1WoJhkNzpOCmF9sYYo5B6I5+5JyjBnMrH3PcfMcE8XHI55SUPy0zKoYgw61T GUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783975643; x=1784580443; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; b=KGMjZgpgF2uIXQzZCAAF7ck9Dc24oGkUS6nUeANcUhSlNmCX0xSKA8h8JpDvqhONCx vZ6oW3T9nKOFsJ0bXtasR2A4F0s8xiYgaQk2K29VZmsAQ8b3Vk7krU7qFQS3e1poS5hE zGQ1OTiLM5oCt5cndC1pFPY8yve7T1YLC9W2ZG+B+dI0xB+ca2oP8LPY6UN+vpNv94uj /IzJLfW+9db0nF5jYogCB/bmjSt30Z2no5TylmnwQdLlQ0ngu5or1BkY1AHxMQPMAlTM yBut0NQ75Z9iQUUXx2VaSjiXR7lzlQ721DQz0aAzRXCqCgTUgbRWJiVSo39UcW61Uvjf qAAQ== X-Forwarded-Encrypted: i=1; AHgh+RoiqxLA83AC/x1ynT4AF1TS//9TO9UBElqK89pjUqqKkh2u5p93cOvWTHCOydfdRkKZGQm+3cAA7uMbgNo=@vger.kernel.org X-Gm-Message-State: AOJu0YxGWmD2dQ7FuGNZOnZTlOxp4bkReZchGnxKifa1xOmJ704zesCY TDer5Z8XPAqC9vQ28i9s6bzB1CHaCnoDwjKNUS8hEJrYEDCoCuqWW6Bi X-Gm-Gg: AfdE7ckmjCeKgjkAtpeo3PcrNzWOpVAOxNwSSJTZL3RME8zUYg4xnT7sxGc7kD6NTl1 QMxmK86PmVQOYoS9j3F+Zhs1ZVwvmYJ9Oc6GGYTZ+kNoEOf6eV2nTiukSZimFZBD4gUjeJfkW8e EqQmfBNaA8gwxl3TqtvECMu0weSsRUnXIr/wZJJ4GM4Xt2AgwshO91bOswkr7CltqISuG/0+3Yz +6dsdXPDcE2qiSTD4oXXT4/rP9XPrbIqVpER+OxS4d6QuFs82sw06xBTFHRiiYmxmyERGcRWXse VTiwvtJgstHtsAU7bLThCKii2GecmFAZ9d28LU823LWyMfD6sCGrNGYOwh7Cjpm8XWHgKOOw1/P SROKzkjcg6M5mrR5BU8YCZW80SyDkpbrLEPMgOoZ072uC+BKfwtYyvM/guuFwtf3Fbf7wwHAgXb hjphjudt3cU7NbAv0w4DWtSIYLSmFkX9wuCokdLat7 X-Received: by 2002:a05:6a00:94ee:b0:848:2f84:72c with SMTP id d2e1a72fcca58-848898b9283mr10236647b3a.63.1783975642656; Mon, 13 Jul 2026 13:47:22 -0700 (PDT) Received: from [192.168.0.13] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f23a600sm362593b3a.6.2026.07.13.13.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 13:47:22 -0700 (PDT) Message-ID: <08508d2133284d49e1da297895c85cf854a97bf3.camel@gmail.com> Subject: Re: [PATCH bpf 1/1] selftests/bpf: Enable BLK_DEV_NBD for raw_tp_writable_reject_nbd_invalid From: Eduard Zingerman To: Shung-Hsi Yu , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, sun jian , Matt Mullins , stable@vger.kernel.org Date: Mon, 13 Jul 2026 13:47:18 -0700 In-Reply-To: <20260713063513.215781-1-shung-hsi.yu@suse.com> References: <20260713063513.215781-1-shung-hsi.yu@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-10 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-07-13 at 14:35 +0800, Shung-Hsi Yu wrote: >=20 > The raw_tp_writable_reject_nbd_invalid test relies on availability of the > nbd_send_request tracepoint, which is only present if the selftest kernel= is > built with CONFIG_BLK_DEV_NBD=3Dy and the kernel built from current BPF s= elftests > config lacks. >=20 > Without it, the bpf_raw_tracepoint_open() call always returns with -2, le= aving > raw_tp_writable_reject_nbd_invalid test always passing without exercising= the > checks bpf_probe_register(). >=20 > Cc: # 5.2.0 > Link: https://lore.kernel.org/bpf/alRtilWhKw4zzMkI@u94a > Signed-off-by: Shung-Hsi Yu > --- > Not sure if fixes tag is the right thing to use here, so use the cc > stable tag instead to get this config change propogated to other stable > branches to make stable BPF CI's job easier. Shung-Hsi, Thank you for figuring this out. I'd suggest we switch to bpf_testmod_test_writable_bare_tp() [1] from the test module to avoid the config dependency and let Sun pack all of this as a single patch-set to simplify backports (if such are necessary). Wdyt? [1] https://lore.kernel.org/bpf/3430dc0a2a141769a596ab21d7abdd86a0a804db.ca= mel@gmail.com/2-tp-test.diff