From: Kumar Gala <galak@codeaurora.org>
To: Sebastian Reichel <sre@debian.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Florian Vaussard <florian.vaussard@epfl.ch>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support
Date: Sat, 26 Oct 2013 01:37:57 -0500 [thread overview]
Message-ID: <085234CB-BD53-4120-AE77-B06FA9314E96@codeaurora.org> (raw)
In-Reply-To: <20131025221850.GA8657@earth.universe>
On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote:
> On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote:
>> On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote:
>>> +- interrupt: should be one of the following
>>> + - <8>: For controllers compatible with twl4030
>>
>> Just checking, but the interrupt is always 8 for this device?
>
> Yes. It's currently hardcoded in drivers/mfd/twl-core.c.
The fact that is hard coded in the driver does not imply that it should be in the device tree binding. Is there an interrupt controller as part of the TWL4030?
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-26 6:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 14:48 [PATCHv6 0/3] DT Support for TWL4030 power button Sebastian Reichel
2013-10-24 14:48 ` [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support Sebastian Reichel
2013-10-25 12:40 ` Florian Vaussard
2013-10-25 12:46 ` Peter Ujfalusi
2013-10-25 14:44 ` Sebastian Reichel
2013-10-25 19:09 ` Grant Likely
2013-10-25 23:40 ` Sebastian Reichel
2013-10-27 13:57 ` Grant Likely
2013-10-25 21:41 ` Kumar Gala
2013-10-25 22:18 ` Sebastian Reichel
2013-10-26 6:37 ` Kumar Gala [this message]
2013-10-26 11:31 ` Sebastian Reichel
2013-10-28 6:31 ` Kumar Gala
2013-10-24 14:48 ` [PATCHv6 2/3] Input: twl4030-pwrbutton: use dev_err for errors Sebastian Reichel
2013-10-25 20:05 ` Aaro Koskinen
2013-10-24 14:48 ` [PATCHv6 3/3] Input: twl4030-pwrbutton: simplify driver using devm_* Sebastian Reichel
2013-10-25 20:05 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085234CB-BD53-4120-AE77-B06FA9314E96@codeaurora.org \
--to=galak@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®