From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDEB025949A for ; Wed, 25 Dec 2024 23:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735169598; cv=none; b=SQctUadcJXLxcAUyRtGxjx7iEr8ISyq+APr+RASBvP7lgDAlJFCUSryxBsak2O+FT8+LxF5KFgRWVal45H+24KDHBkgKkPr1G0cWv+oySPj6j70sn+AuxMLmAcMamLCb7rkTTqyvuT30PlwRPDWrJtXBZuigiBxKOfEqBS/hZGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735169598; c=relaxed/simple; bh=b/4CAQurNdRUWZmylZo59Dst9tuDn1kjhKK7C8/UQao=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=SsrdBnb+eHUHnCRxYTQiffPy3ZJXUyDJXs+mUCRghs0sp1D6Wt7IBXD8AxSrTlSFeubmuesSxlwZQH0V9GUlhai/har47RU+/rqyPaYl9y5Ao81SrsOTFSeQnlrfBbzLjFPY6rK4DTa4KdNDJCohyLtmtL+XVobrCk/GzoPp4xM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cjr1dm9v; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cjr1dm9v" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d88c355e0dso992228a12.0 for ; Wed, 25 Dec 2024 15:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735169593; x=1735774393; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uR3kpuXskFf7I4KKc90olyo/Ogazato/TXgv2xlhRjs=; b=Cjr1dm9vTIYdvy4NSLysF1b80KpIOmk0tJ16RPgzcxVqgqSuiB8XWANBg99vkiJ+tH /s11Ikj9XuNZcU/T5vo9CiBazo+z6USauJNsCyMoLAxSpUpu3FbAknhvZ1iNyK6qINjT /uBgBuV6MmCsPSRhE9Z2mo2ZAxoGBN/oQIkAgJDNQunk0GCQlPRG7VmSKUq8KycuPm4V kPIl1OtDU7rQky1hc4ZmMv+RqAMDndj/rGVkYJZThdErepfPV3dcVDNhBdnlefrRMrLc t738kH7X88O9gWZz5kGalIEOWiOOjkmjI6d5Y0dTV9fdmx0lYSwwihroVmRkQ5Ex5ruV oUPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735169593; x=1735774393; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uR3kpuXskFf7I4KKc90olyo/Ogazato/TXgv2xlhRjs=; b=q6JxmbQ5NJUg0r3sZekA9muZ9HEN7kBMX6xoO7RqTSDIM43tZXPdY8upGTvLn/YREZ NsuWzS8xLg8xyZ5xiDczrEPJ7t1QTmGfxM6R3cRx/N+ncFnJRbrWP1UDPBHe9EyOcbns ak0ZQEmy+t8f8xPSkWF2LyX/7UeHDjxt+h7c2mGry2+ceTaMO5GCr3CtEZl9dHsQluhX zJkT+tsrRH1n/IuQ4WleSs0gbOAXWiBdleOeeazAEr0ytBJsN+WJp5sJQ/+Xp8V9hwrf N9I+HXQWq4QXyob4tvzhHju4gPZ6iGYRof8UcHsNMYOjZ27TBMGVndjTy+e7r+okrMM4 laOA== X-Forwarded-Encrypted: i=1; AJvYcCUuIl4F+RgJtX2i6W/gByYIgD9lkvFkXMvhOz3yweVjOQXhXUbMNj1+2UeJNtcJIVQU8pNLEsOb5nB6MJw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7EklgKd3jVuXKCFh39ls9XWxTMpkGpYcAekhUVwBdtJxuTmBe ESUVFYC86fbd07KfwktfH5HCf/9wATB3ADZ+kWJQJ6oFVl7v3AmR X-Gm-Gg: ASbGncvFs78B8DI24yiCMOdyi1VhozC5O0m9EF1yz8GDhCVGtJq0VNdIm+P4a5zAwrb guo7rfJLVIwUqy3Siq8M7jtWpkX0a0l3F6CXID8ExifnExj9b84llzAYxj3hPPq3Ithr/+KJH9J B3QLtfV9Zcc/sK4RWPn7SxjSj7KmD69qiMXCpyx1uHV9BbZVY2hpxCU1CRheLNygNiEyPG9pMt2 n2hBpPRKqg9F0IrP5EEUmEbvDUyHlEE3sqDUIVVVWCuiMxgAqwZmmHft9j5x1OvImjT0/U5fw== X-Google-Smtp-Source: AGHT+IF9mjHRw6w3JOz4cY6cnRayvhjCIl7eq3NT6itpFbdPUesE16ob3yYA9Iv5yPFjgUN3UZkjjQ== X-Received: by 2002:a05:6402:3553:b0:5d0:fc80:c4d1 with SMTP id 4fb4d7f45d1cf-5d81dd8087emr17925152a12.14.1735169592822; Wed, 25 Dec 2024 15:33:12 -0800 (PST) Received: from smtpclient.apple ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80701bf20sm8122461a12.83.2024.12.25.15.33.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Dec 2024 15:33:11 -0800 (PST) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: [PATCH 08/11] x86/mm: enable broadcast TLB invalidation for multi-threaded processes From: Nadav Amit In-Reply-To: <20241223025751.3268975-9-riel@surriel.com> Date: Thu, 26 Dec 2024 01:32:58 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , "open list:MEMORY MANAGEMENT" Content-Transfer-Encoding: quoted-printable Message-Id: <08542B0E-71E2-4DC5-8C9F-5C09F0376A50@gmail.com> References: <20241223025751.3268975-1-riel@surriel.com> <20241223025751.3268975-9-riel@surriel.com> To: Rik van Riel X-Mailer: Apple Mail (2.3826.300.87.4.3) >=20 >=20 > On 23 Dec 2024, at 4:55, Rik van Riel wrote: >=20 > @@ -1049,9 +1341,12 @@ void flush_tlb_mm_range(struct mm_struct *mm, = unsigned long start, > * a local TLB flush is needed. Optimize this use-case by = calling > * flush_tlb_func_local() directly in this case. > */ > - if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids) { > + if (IS_ENABLED(CONFIG_CPU_SUP_AMD) && = mm->context.broadcast_asid) { > + broadcast_tlb_flush(info); >=20 I think broadcast_asid is defined within an ifdef, so the IS_ENABLED() = here would not save you from having to use ifdef.