From: Markus Elfring <Markus.Elfring@web.de>
To: Fidal palamparambil <rootuserhere@gmail.com>,
linux-modules@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Gomez <da.gomez@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH] kprobe_event_gen_test : Fix error handling and resource cleanup
Date: Sat, 6 Sep 2025 17:55:06 +0200 [thread overview]
Message-ID: <08543dfc-85e3-4f21-bf30-de612a47504e@web.de> (raw)
In-Reply-To: <20250906131559.200-1-rootuserhere@gmail.com>
> This commit addresses several issues …
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94
…
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -129,6 +129,7 @@ static int __init test_gen_kprobe_cmd(void)
> "gen_kprobe_test");
> if (IS_ERR(gen_kprobe_test)) {
> ret = PTR_ERR(gen_kprobe_test);
> + gen_kprobe_test = NULL;
May the repetition be reduced for this assignment statement?
> goto delete;
How do you think about to use an additional label?
> }
…
Regards,
Markus
next prev parent reply other threads:[~2025-09-06 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 13:15 Fidal Palamparambil
2025-09-06 15:55 ` Markus Elfring [this message]
2025-09-07 1:23 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08543dfc-85e3-4f21-bf30-de612a47504e@web.de \
--to=markus.elfring@web.de \
--cc=da.gomez@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rootuserhere@gmail.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®