From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C9A1420D0; Fri, 31 May 2024 10:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.248 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717153096; cv=none; b=foMEN2AXo42vpMPG5q+TnpCjbADyjtXcvgJrc5SA9DX4rUAWhawmLm+TvOsR+HcdzjARxAG6X3hHi/xvUC62DhEbvroLWIO0gZhZW4oV+OvUELiwsULW0rroLS0bgAjCIo8ZsMENaWcFWUBxQbsfHsQLtF3I90toO17wG+lF70E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717153096; c=relaxed/simple; bh=kbYQ2x5xDscr9P7XHXIxk/5KdAh2eC4NAzbyU0YJ3HE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=uQR39IcRiYi5jDrE6KqNHSAszMNYvZDK0dLpP8eYaXkywbyffRHHBxjjTI2Uk1DDzFUgTtM6meDwf8Yiz+FiFaLfsZnRKr+2K56ul3PcLJoMIVAiecBBFxA36jccYiDx4SXU8Bv95PPjY0hiBgnGOAT0n+xk88925KKePpEp3DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=oK6eeztN; arc=none smtp.client-ip=198.47.23.248 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="oK6eeztN" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 44VAvXH5079927; Fri, 31 May 2024 05:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1717153053; bh=hjtdY2sRv/3Z2vbHsQ/ld4i7cSC58nLl8ghKakpaSR0=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=oK6eeztNfdoiPYCwCSlA1WgYvfUjzbUmrRUgFJ+YKeI8U3j1a7UiLvYErfx1jWI5d y/yek9LTAxEDobjM8UcErw5+eUOjtBQ8zHEsfBv0X0VES5JrJfR48pnCNQmBflJGQK Ch6TF5Agi/q5Hu6WdhJ0Eglb9EkiIlbQ+RQqQkA0= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 44VAvXew012283 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 May 2024 05:57:33 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 31 May 2024 05:57:32 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 31 May 2024 05:57:32 -0500 Received: from [172.24.227.193] (devarsht.dhcp.ti.com [172.24.227.193] (may be forged)) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 44VAvNwo116858; Fri, 31 May 2024 05:57:24 -0500 Message-ID: <0858f5d9-a694-7ee4-0edf-3f0610703b92@ti.com> Date: Fri, 31 May 2024 16:27:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions Content-Language: en-US To: Randy Dunlap , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , References: <20240530165925.2715837-1-devarsht@ti.com> <20240530171740.2763221-1-devarsht@ti.com> <4951656c-2d15-49f6-89d8-aa7b5c333ec7@infradead.org> From: Devarsh Thakkar In-Reply-To: <4951656c-2d15-49f6-89d8-aa7b5c333ec7@infradead.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Hi Randy, Thanks for the review. On 31/05/24 04:14, Randy Dunlap wrote: > > > On 5/30/24 10:17 AM, Devarsh Thakkar wrote: >> Add documentation for rounding, scaling, absolute value and difference, >> 32-bit division related macros and functions exported by math.h header >> file. >> >> Signed-off-by: Devarsh Thakkar >> --- >> V1->V9 (No change) >> V10: Patch introduced >> --- >> Documentation/core-api/kernel-api.rst | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst >> index ae92a2571388..fb467783d491 100644 >> --- a/Documentation/core-api/kernel-api.rst >> +++ b/Documentation/core-api/kernel-api.rst >> @@ -185,6 +185,12 @@ Division Functions >> .. kernel-doc:: lib/math/gcd.c >> :export: >> >> +Rounding, absolute value, scaling and 32bit division functions > > 32-bit > please. > Good catch. Also I see some division functions supporting non-32bit functions too, so I would make it as below : Rounding, absolute value, division and 32-bit scaling functions --------------------------------------------------------------- Regards Devarsh