mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Chen-Yu" <Chen-Yu.Chen@amd.com>
To: hugo@hsal.es, "Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <siqueira@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Cc: Roman Li <Roman.Li@amd.com>,
	Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] drm/amd/display: Leave self-refresh before an ABM level update
Date: Mon, 16 Nov 2026 16:58:49 +0800	[thread overview]
Message-ID: <085c307e-8671-4ac4-8bd4-b7e42fb69ae7@amd.com> (raw)
In-Reply-To: <20261113-amdgpu-psr-abm-update-next-v2-0-27ce790856ea@hsal.es>

Thanks for v2.

For the series:
Reviewed-by: Chenyu Chen <chen-yu.chen@amd.com>

On 11/14/2026 3:40 AM, Hugo Sales via B4 Relay wrote:
> [Some people who received this message don't often get email from devnull+hugo.hsal.es@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Writing panel_power_savings while the eDP is in PSR hangs DMUB on a
> Cezanne laptop (DCN 2.1). An ABM level change on its own is a fast
> update, so the new level reaches DMUB with the panel still in
> self-refresh. Chenyu Chen confirmed the same on Renoir
> 
> Patch 1 adds helpers that tell whether a PSR or Replay event is already
> set on a stream. Patch 2 is the fix. It sets the PSR and Replay
> hw_programming events around the DC update that carries the new level,
> and clears only the events it set. An event that a full update, a
> modeset or a PSR SU dirty rect change set stays set, for that code to
> clear. Patch 3 stops amdgpu_dm_commit_planes() from sending the same
> level again after the connector update loop sent it, so one level change
> leaves self-refresh once
> 
> "drm/amd/display: Don't force a modeset when the ABM level changes" [1]
> sends property changes down this fast path, so it needs this series first
> 
> HDR metadata may have the same problem. When the HDR static metadata
> changes while HDR stays on, the commit is a fast update too, and the
> connector loop in amdgpu_dm_atomic_commit_tail() sends the new HDR
> infopacket to DC with the panel still in self-refresh. I have no panel
> with HDR and PSR or Replay to try it on, and the VRR and AVI infopackets
> already reach DC the same way. Does an infopacket update in self-refresh
> need the same pause?
> 
> v2:
> - Clear the events right after the DC update, under dc_lock, instead of
>   on the next fast commit (Chenyu)
> - Only clear the events this update set, so an event that a full
>   update, a modeset or a dirty rect change set in the same commit stays
>   set
> - Add amdgpu_dm_psr_event_is_set() and amdgpu_dm_replay_event_is_set(),
>   with KUnit tests
> - Send a changed level once per commit, so it leaves self-refresh once
> 
> v1: https://lore.kernel.org/r/20261031130002.2335615-1-hugo@hsal.es
> 
> [1] https://lore.kernel.org/r/20261102-abm-sysfs-commit-v1-2-e5addfd9539a@hsal.es
> 
> ---
> Hugo Sales (3):
>       drm/amd/display: Add helpers to check PSR and Replay events
>       drm/amd/display: Leave self-refresh before an ABM level update
>       drm/amd/display: Send a changed ABM level once per commit
> 
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  83 +++++++++++++++--
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c  |  24 +++++
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.h  |   2 +
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c   |  25 +++++
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_replay.h   |   3 +
>  .../display/amdgpu_dm/tests/amdgpu_dm_psr_test.c   |  60 ++++++++++++
>  .../amdgpu_dm/tests/amdgpu_dm_replay_test.c        | 102 +++++++++++++++------
>  7 files changed, 263 insertions(+), 36 deletions(-)
> ---
> base-commit: ba496bb837882eb1af58f41572fc289e46c77b8c
> change-id: 20261113-amdgpu-psr-abm-update-next-de20bc23b12c
> 
> Best regards,
> --
> Hugo Sales <hugo@hsal.es>
> 
> 


      parent reply	other threads:[~2026-11-16  8:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 19:40 Hugo Sales via B4 Relay
2026-11-13 19:40 ` [PATCH v2 1/3] drm/amd/display: Add helpers to check PSR and Replay events Hugo Sales via B4 Relay
2026-11-13 19:40 ` [PATCH v2 2/3] drm/amd/display: Leave self-refresh before an ABM level update Hugo Sales via B4 Relay
2026-11-13 19:40 ` [PATCH v2 3/3] drm/amd/display: Send a changed ABM level once per commit Hugo Sales via B4 Relay
2026-11-16  8:58 ` Chen, Chen-Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=085c307e-8671-4ac4-8bd4-b7e42fb69ae7@amd.com \
    --to=chen-yu.chen@amd.com \
    --cc=Nicholas.Kazlauskas@amd.com \
    --cc=Roman.Li@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=hugo@hsal.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®