mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Nico Pache <npache@redhat.com>,
	linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	rientjes@google.com, hannes@cmpxchg.org, rdunlap@infradead.org,
	mhocko@suse.com, Liam.Howlett@oracle.com, zokeefe@google.com,
	surenb@google.com, jglisse@google.com, cl@gentwo.org,
	jack@suse.cz, dave.hansen@linux.intel.com, will@kernel.org,
	tiwai@suse.de, catalin.marinas@arm.com,
	anshuman.khandual@arm.com, dev.jain@arm.com, raquini@redhat.com,
	aarcange@redhat.com, kirill.shutemov@linux.intel.com,
	yang@os.amperecomputing.com, thomas.hellstrom@linux.intel.com,
	vishal.moola@gmail.com, sunnanyong@huawei.com,
	usamaarif642@gmail.com, wangkefeng.wang@huawei.com,
	ziy@nvidia.com, shuah@kernel.org, peterx@redhat.com,
	willy@infradead.org, ryan.roberts@arm.com,
	baolin.wang@linux.alibaba.com, baohua@kernel.org,
	mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
	rostedt@goodmis.org, corbet@lwn.net, akpm@linux-foundation.org
Subject: Re: [PATCH v6 0/4] mm: introduce THP deferred setting
Date: Wed, 21 May 2025 13:33:01 +0100	[thread overview]
Message-ID: <085de112-7238-4bbe-822c-198a7291ea89@lucifer.local> (raw)
In-Reply-To: <db190425-9959-4d0c-b928-c537c69bc5a7@redhat.com>

Fundamentally I trust you to make sure this all goes correctly so let's not
belabour the point or delay things here :)

So in that vein, Nico - I would sugesst for future respins adding a really
clear bit to the header as David suggested :) also update the cover letter
tests so it isn't reliant on a possibly ephemeral web link.

But otherwise let's proceed as was.

On Wed, May 21, 2025 at 02:24:45PM +0200, David Hildenbrand wrote:
> > >
> > > Anyhow, to me the dependency is obvious, but I've followed the MM meeting
> > > discussions, development etc.
> >
> > Right but is it clear to Andrew? I mean the cover letter was super unclear
> > to me.
>
> I mean, assuming that it would not be clear to Andrew (and I think it is
> clear to Andrew), I we would get CCed on these emails and could immediately
> scream STOOOOOP :)
>
> And until this would hit mm-stable, a bit more time would pass.
>
> >
> > What's to prevent things getting merged out of order?
>
> Fortunately, there are still people working here and not machines (at least,
> that's what I hope).

Obligatory link to this :P

https://www.youtube.com/watch?v=5lsExRvJTAI

>
> > And do people 'just
> > have to remember' to resend?
>
> Yes, in this case Nico wants to get his stuff upstream and must drive it
> once the dependencies are met IMHO.
>
> >
> > If there's a requirement related to the ordering of these series it really
> > has to be expressed very clearly.
>
> Jup. I'll note that for now there was no strict rule what to tag as RFC and
> what not that I know of. Of course, if people send broken, half-implemented,
> untested ... crap, it should *clearly* be RFC.
>
> People should be spelling out dependencies in any case (especially for
> non-RFC versions) clearly.
>
> I'll note that even if there would be a rule, I'm afraid we don't have a
> good place to document it (and not sure if people would find it or even try
> finding it ...) :/

Yeah... :)

>
> A big problem is when some subsystems have their own rules for how to handle
> such things. That causes major pain for contributors ...

Yeah, I wish there was something more general.

>
> --
> Cheers,
>
> David / dhildenb
>

Cheers, Lorenzo

  reply	other threads:[~2025-05-21 12:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15  3:38 Nico Pache
2025-05-15  3:38 ` [PATCH v6 1/4] mm: defer THP insertion to khugepaged Nico Pache
2025-05-20  7:43   ` Yafang Shao
2025-06-14 11:25   ` Klara Modin
2025-06-17 17:52     ` Nico Pache
2025-05-15  3:38 ` [PATCH v6 2/4] mm: document (m)THP defer usage Nico Pache
2025-05-15  3:38 ` [PATCH v6 3/4] khugepaged: add defer option to mTHP options Nico Pache
2025-05-15  3:38 ` [PATCH v6 4/4] selftests: mm: add defer to thp setting parser Nico Pache
2025-05-20  9:24 ` [PATCH v6 0/4] mm: introduce THP deferred setting Yafang Shao
2025-05-21 10:19   ` Nico Pache
2025-05-21 11:35     ` Yafang Shao
2025-05-20  9:42 ` Lorenzo Stoakes
2025-05-21 10:41   ` Nico Pache
2025-05-21 11:24     ` Lorenzo Stoakes
2025-05-21 11:46       ` David Hildenbrand
2025-05-21 12:00         ` Lorenzo Stoakes
2025-05-21 12:24           ` David Hildenbrand
2025-05-21 12:33             ` Lorenzo Stoakes [this message]
2025-05-21 12:40               ` David Hildenbrand
2025-05-29  4:26       ` Nico Pache

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=085de112-7238-4bbe-822c-198a7291ea89@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@gentwo.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jglisse@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=peterx@redhat.com \
    --cc=raquini@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=sunnanyong@huawei.com \
    --cc=surenb@google.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=usamaarif642@gmail.com \
    --cc=vishal.moola@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=yang@os.amperecomputing.com \
    --cc=ziy@nvidia.com \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®