mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
	kvm@vger.kernel.org, bp@alien8.de
Cc: mingo@redhat.com, tglx@linutronix.de,
	dave.hansen@linux.intel.com, seanjc@google.com,
	pbonzini@redhat.com, thomas.lendacky@amd.com,
	michael.roth@amd.com, zhi.wang.linux@gmail.com,
	David Rientjes <rientjes@google.com>,
	stable@kernel.org
Subject: Re: [PATCH v6] x86/sev: Add SEV-SNP guest feature negotiation support
Date: Wed, 18 Jan 2023 11:41:23 +0530	[thread overview]
Message-ID: <086444df-568b-d394-c190-9f206cad9222@amd.com> (raw)
In-Reply-To: <20230116091036.72579-1-nikunj@amd.com>



On 16/01/23 14:40, Nikunj A Dadhania wrote:
> +static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
> +					     unsigned int reason, u64 exit_info_2)
> +{

Found this today:

In file included from arch/x86/kernel/sev.c:519:
At top level:
arch/x86/kernel/sev-shared.c:167:24: warning: ‘sev_es_ghcb_terminate’ defined but not used [-Wunused-function]
  167 | static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
      |                        ^~~~~~~~~~~~~~~~~~~~~

I am wondering why I did not get this error in my build testing.

sev-shared.c gets included from two files boot/compressed/sev.c and kernel/sev.c, sev_es_ghcb_terminate() 
has only one user. I will move helper function to boot/compressed/sev.c and send an updated version.


Regards
Nikunj

      parent reply	other threads:[~2023-01-18  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16  9:10 Nikunj A Dadhania
2023-01-17 20:25 ` Tom Lendacky
2023-01-18  6:11 ` Nikunj A. Dadhania [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=086444df-568b-d394-c190-9f206cad9222@amd.com \
    --to=nikunj@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rientjes@google.com \
    --cc=seanjc@google.com \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    --cc=zhi.wang.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®