From: Kamil Konieczny <k.konieczny@partner.samsung.com>
To: Marek Vasut <marex@denx.de>, Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: mxs-dcp: Add empty hash export and import
Date: Tue, 16 Jan 2018 18:33:14 +0100 [thread overview]
Message-ID: <08646712-9fc0-4f61-3f3d-31fc7cb6cf90@partner.samsung.com> (raw)
In-Reply-To: <fbdc8a2b-4ed3-cc1c-246f-10c3c05a2ab0@denx.de>
On 16.01.2018 17:56, Marek Vasut wrote:
> On 01/16/2018 05:16 PM, Kamil Konieczny wrote:
>> Crypto framework will require async hash export/import, so add empty
>> functions to prevent OOPS.
>
> Shouldn't this be handled on the subsystem level with some
>
> if (foo->bar)
> foo->bar();
>
> instead?
I am sorry, I should write more elaborate description for patch.
It is handled by subsystem. Most drivers have them, and testmgr is testing for
export/import and drivers without them fail internal crypto tests,
so I prepared patch which removed these two wrappers from crypto framework.
In summary: export/import are now required, so crypto framework can work properly.
--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland
next prev parent reply other threads:[~2018-01-16 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180116161641eucas1p1f776ccf0d08da2d3b670e5b2ad550ea6@eucas1p1.samsung.com>
2018-01-16 16:16 ` Kamil Konieczny
2018-01-16 16:56 ` Marek Vasut
2018-01-16 17:33 ` Kamil Konieczny [this message]
2018-01-16 17:28 ` Fabio Estevam
2018-01-16 18:28 ` Kamil Konieczny
2018-01-18 17:53 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08646712-9fc0-4f61-3f3d-31fc7cb6cf90@partner.samsung.com \
--to=k.konieczny@partner.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®