From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66433E0228 for ; Thu, 14 May 2026 13:22:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764923; cv=none; b=PfnLXTLzOdWl4kfPa1ENmK3UrVyHicfQbvirrp861EXe9PMrIgwXflvhBsKd0BnvGdHjgbvjOxGnQX0z+VfwHHdOxBpK5x1A3LKcpGZoIKtghfH16vRuBJSk15/xd1V/s5WxjTpfL+QOVUrBo/TakTqYnkK7z6EIfDHknCINi8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764923; c=relaxed/simple; bh=bNRPHmgQjciXF+FTQCi2BqEOotAq9dF0V3DH2FPFDDM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HtAUCRg3j/yz9tx7QMXY9LhC4/cwNUfT1OyLuigQGLSpKZnQhf7mfL/OgiuW9xyd1+VEIlralnxDnGZZ9vye7HAvM73hOONAraqDrvkRpcYgKvbdB1/vZxaj1bLd29l4yis/xe9DJdiqhF5a2GzTVyv4kP+2bFm/n403fgTlyV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PPqA/9tZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RdIJRzRY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PPqA/9tZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RdIJRzRY" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EBeQmF3951584 for ; Thu, 14 May 2026 13:21:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7pvMXUwz6BD2dXWrjN9UdcJP372MyTgcXC7YJhQfJjU=; b=PPqA/9tZwW27lyDS V8zuUK628KB70pjrJoX43JD5788mlrTobvNMj/HoWU21eAMEKIngfg7MPzoSLVoZ I4q0KZq8T3bU3iErWhWIEYwvcF3TKiqSksdFZwoXn2CRtF7xCUx8sYjiiyEZRqcn ZTRHTwwtCJLRrUZ3W9Ioc8iWSeDTz8jwmugtFhSVIckuoizYWg6/zWwSYYCNTE9j onOrWxNdmdz0ZbqiwtAFZSYnsWiBgyZb10JbaOaee2gzKtvaNjqGYPPfy6h2Vxzt 1AmCVH8CE6bZUxxg5XwfpGYPXgSlVMyTUA6TIpqi7i8x57Il8nexgidCaXfKE8Sv mqw1YQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e57kssnq7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 13:21:59 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-366015bca9bso6320594a91.1 for ; Thu, 14 May 2026 06:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778764919; x=1779369719; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7pvMXUwz6BD2dXWrjN9UdcJP372MyTgcXC7YJhQfJjU=; b=RdIJRzRYrXJuSF+Y3Q0ad6BsiZ0jazNtbgYMps1ulpN9MSbX0UwY/OXRv/nLxosPGL o0Rd+Hq3EkGlkDGlHpbokzv8uQuQKTESZdPvNGG06qGSMJhRB+MSuLCFlQcC0i4uSBUA umRqf3KcCV+E8TqYh1Yj2mkxjWic1E8QBNdeZBCvt1yRHXlMILZD8tcHk+KvxKR/xMQ/ JLXxQdCB4aTtDIdrxS/kwXvOklb+36+jYQJX16snJ2h1eKzzqrDqH2vNFHgp1mJRsQis ey6yWzyyXjPwD+Ve7R99GF/djlcpTYtIxlCF14DjeToJ0llf61c2792iA1cTSGNHrDQM oQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778764919; x=1779369719; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7pvMXUwz6BD2dXWrjN9UdcJP372MyTgcXC7YJhQfJjU=; b=hwU+5e0lsIhURJr1fgVrSgiRC7gqRlXdjIUFgHBEDko2lHOGae5x5Gm3+edMmj4MKN uhesGDRt1rMs+ogDJSIZVuT1NxfzTlAudnGoW2GcaFMfLv4rYsMNS3JTiI4ayi9zo+w1 UGK3hoiejh/vkNJd76BfrDDCH/2zJryRPfpQFXObpWrJqO4TpWNukiPYLBKg0X3AH1jj 4lh0dgWuoWh5C7+RXqpeT5D4MjHCVIBT4SiuPPUhWO2GUN9cF6hky3sQ8FMHE0R/nCmr DlSm7C7cEvs199ojlPedUSbYtcdXcre14Q9RAG+qYG+21/sIoremHrGCWk6IS9NRLTt/ n39Q== X-Forwarded-Encrypted: i=1; AFNElJ9Ssgkrc8ZdBWxSF5qhr5p1VB9vuSu7YuJRNRfKFC/1+I9YRIk37V7+Y/wl3Sh+RZs0Kq2nCNRkv1ZQjkY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb2l5gYakgg51ZNUhMq55EIfnsjUk4BH5NTek72WvzA+xFFlla n6uZ4thQFFVGVkYAzW6x3u5rlje3He8o6rP212tT/WVYFbU4cui52hm0F+i98ErC4TocS8A/MmS QI4UHgVBYbc4BFQqpQDRv3baf78dDmyLpx0JbDuokoDsl8cVeHpK5Iun8qgyOwk0Ta30= X-Gm-Gg: Acq92OHPOyETzjVxDvYrc6f0sOrRVcoWlO90NlXDk4UJgB/DKuchTp1V4V2aMvCpQVZ 3HIAgFdgcQly5fhh5EOvDbqlFRhlH3Yhx1mMuSX7RzQmQlQVH4o+oFbRasdJSNS072ZeDwgJukJ zULZxOPhhNO+TshJ5NwPr734p3mBp0xvH3exJievQGRlrRFPbwNqLwMo7ftMuu13aRTn37lo3Z0 e49skwvS9xYC/KB+DGekD1SCYrQ/qLMmSYHxcslA8aPb+Oc0GFNYSutxN4J3GzA5a52v1l7Ty5h cMGylsB9WEApovELjCsA6LW1kqjobkUCiDNIhx9IfJDVpajeQOU/cxXQzt5BjA/KbvTztCPRuQ6 F5StLGvrExw2jMw6qjZ/7qGSWzzGazXAVZJwt42prX4OXTE94o7b895EDXQ3uDIP8U+5bSu2PfO wHNeGUjWx3+scM4yLfCNW273Q3WC4C2MobPaD/6RZ+ X-Received: by 2002:a17:90a:82:b0:369:3c3d:f899 with SMTP id 98e67ed59e1d1-3693c3e0547mr1013198a91.2.1778764918392; Thu, 14 May 2026 06:21:58 -0700 (PDT) X-Received: by 2002:a17:90a:82:b0:369:3c3d:f899 with SMTP id 98e67ed59e1d1-3693c3e0547mr1013178a91.2.1778764917844; Thu, 14 May 2026 06:21:57 -0700 (PDT) Received: from [10.190.200.212] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3692a94205asm975092a91.7.2026.05.14.06.21.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 06:21:57 -0700 (PDT) Message-ID: <0867695e-d1f2-46ff-80d7-564b7d646e93@oss.qualcomm.com> Date: Thu, 14 May 2026 18:51:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Add psci reboot-mode edl To: Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260505-glymur_reboot_mode-v1-1-59fe3e9a6868@oss.qualcomm.com> Content-Language: en-US From: Pankaj Patil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: IQmFguk71iP2PliSD7wulJy1d49-iK02 X-Authority-Analysis: v=2.4 cv=KZbidwYD c=1 sm=1 tr=0 ts=6a05cc77 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NZaXKhJlTt4XDMuIunoA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDEzNCBTYWx0ZWRfX1V8xzPAvNDQD yfesdNOIT4cpFuhkCaWrCQ+n7nmQUGkjFBRIoZLMVLaiPV5f+W3FKCDOfLv3vniugpn5B6iM9sX tCsAiI+/G6goXZJK3nqe+vGQZOaOWnMLPlQ3Twc6gkJuOlZvQrAr/D9nfcgchgN88YaWrd8nE1k AkM+ge9nR3dj22QitZZyL5aGx+nFLNq1yV0XUdXuNANeyt85OSuUrfHKcFJT94J6p95L51u/Imu /6wt6GH0N8GnU47Vks/pq41wiUqiDoTyNRY6UqQbbPNEhUH6OYX0gaLxirdT1ouitAKLxBenBUs shErASCoeMeeMu49rDSnqu9sl+zRN98oeWml/Bo/2wrHYEYZxaWnH9SDNR1iGnmePN1wFO5vFRA pi6/34ztmrr3DSKOBaHpjie+TLHh0fUey6k3nJ+F4sqf//AgPPKjillk1w4QgU7cC9yw+kwmjWS NpU1rM1HMTv9CapgGzQ== X-Proofpoint-ORIG-GUID: IQmFguk71iP2PliSD7wulJy1d49-iK02 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140134 On 5/10/2026 8:58 AM, Bjorn Andersson wrote: > On Tue, May 05, 2026 at 07:07:27PM +0530, Pankaj Patil wrote: >> Add PSCI SYSTEM_RESET2 reboot-modes for glymur to be invoked by the psci > > "Glymur" > >> reboot-mode driver. > > https://docs.kernel.org/process/submitting-patches.html#describe-your-changes > states that you should start your commit message by describing the > "problem" your patch is addressing. This commit message fully assumes > that the reader already knows everything about this topic and why this > should be added. > >> >> The following modes are defined: >> - edl: reboot into emergency download mode for image loading via >> the Firehose protocol. > > I presume that would be the Sahara protocol, but you don't need to be > specific about how that implementation works. It's sufficient to say > that "edl" reboots the device into "emergency download mode (EDL)". > Sure, Will update >> >> Support for these modes is dependent on the psci firmware > > What are the implications of that? > Without the firmware support, device will reboot instead of switching to edl mode >> >> Signed-off-by: Pankaj Patil >> --- >> arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 6 ++++++ >> arch/arm64/boot/dts/qcom/glymur.dtsi | 2 +- >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> index 2852d257ac8c..397519e95ca1 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi >> @@ -560,6 +560,12 @@ &pon_resin { >> status = "okay"; >> }; >> >> +&psci { >> + reboot-mode { >> + mode-edl = <0x80000000 0x1>; > > Does the statement about "psci firmware" somehow relate to the fact that > this is defined in the crd.dtsi? > Will add in the soc dtsi >> + }; >> +}; >> + >> &tlmm { >> gpio-reserved-ranges = <4 4>, /* EC TZ Secure I3C */ >> <10 2>, /* OOB UART */ >> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi >> index f23cf81ddb77..7f426efe40ab 100644 >> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi >> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi >> @@ -382,7 +382,7 @@ pmu { >> interrupts = ; >> }; >> >> - psci { >> + psci: psci { >> compatible = "arm,psci-1.0"; >> method = "smc"; >> >> >> --- >> base-commit: 9d0d467c3572e93c5faa2e5906a8bbcd70b24efd >> change-id: 20260407-glymur_reboot_mode-4441770e6a8a >> prerequisite-message-id: <20260427-arm-psci-system_reset2-vendor-reboots-v21-0-dcf937775e73@oss.qualcomm.com> > > As far as I can tell from the discussion, that's not settled yet. > Not sure what you want me to do with this patch then... > > Regards, > Bjorn Shivendra will be picking up this patch in next revision of psci reset series, I should've sent as RFC > >> prerequisite-patch-id: 70829f19896a982ef4ac19fa82bf571b9eb6defa >> prerequisite-patch-id: 600337ba5717c51204c4f426acb28bd6287e56ec >> prerequisite-patch-id: e7a6e85c94e35b71c9813c322e811a270233c854 >> prerequisite-patch-id: 7bb3e4b151f32129e8ce5d3c1015150cbd741d13 >> prerequisite-patch-id: a61561c5070b9485399a840ff48252842393f01a >> prerequisite-patch-id: c7f5c86cf5f88c6d5dd576565bcce25ee3848b19 >> prerequisite-patch-id: e4d851cd0a6dfb96d62e4c9d3ebfa1422b9571a6 >> prerequisite-patch-id: e6ffbbec586e6c4b508bd366615e33928a910190 >> prerequisite-patch-id: 8ae267aee51f48992d2232f18dc5795b08fd8e54 >> prerequisite-patch-id: 10b585e49a96767c3324c9e3c623a4716a641fda >> prerequisite-patch-id: 5abbfae8b6577899e0423b36b4690adf1046cac2 >> prerequisite-patch-id: edb89ac23b7a3d5ade9b9cc1e1a77ee4d1a663cf >> prerequisite-patch-id: 555f1b64be3631d6286f2f1e140dc38c6935d646 >> >> Best regards, >> -- >> Pankaj Patil >>