From: Jens Axboe <axboe@kernel.dk>
To: "Javier González" <jg@lightnvm.io>
Cc: "Johannes Thumshirn" <jthumshirn@suse.de>,
"Matias Bjørling" <mb@lightnvm.io>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matias Bjørling" <matias@cnexlabs.com>
Subject: Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.
Date: Wed, 6 Sep 2017 09:13:46 -0600 [thread overview]
Message-ID: <086e6df7-65d8-57b7-6605-d585985a3ddf@kernel.dk> (raw)
In-Reply-To: <B52A428A-99AA-4CE3-8C30-3C2BAA30678D@lightnvm.io>
On 09/06/2017 09:12 AM, Javier González wrote:
>> On 6 Sep 2017, at 17.09, Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 09/06/2017 09:08 AM, Johannes Thumshirn wrote:
>>> On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote:
>>>> Check for failed mempool allocations and act accordingly.
>>>
>>> Are you sure it is needed? Quoting from mempool_alloc()s Documentation:
>>> "[...] Note that due to preallocation, this function *never* fails when called
>>> from process contexts. (it might fail if called from an IRQ context.) [...]"
>>
>> It's not needed, mempool() will never fail if __GFP_WAIT is set in the
>> mask. The use case here is GFP_KERNEL, which does include __GFP_WAIT.
>
> Thanks for the clarification. Do you just drop the patch, or do you want
> me to re-send the series?
No need to resend. I'll pick up the others in a day or two, once people
have had some time to go over them.
--
Jens Axboe
next prev parent reply other threads:[~2017-09-06 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 15:01 [PATCH 0/6] lightnvm: pblk bug fixes for 4.14 Javier González
2017-09-06 15:01 ` [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc Javier González
2017-09-06 15:08 ` Johannes Thumshirn
2017-09-06 15:09 ` Jens Axboe
2017-09-06 15:12 ` Javier González
2017-09-06 15:13 ` Jens Axboe [this message]
2017-09-06 15:14 ` Javier González
2017-09-06 15:20 ` Jens Axboe
2017-09-06 18:28 ` Javier González
2017-09-06 15:12 ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 2/6] lightnvm: pblk: initialize debug stat counter Javier González
2017-09-06 15:15 ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 3/6] lightnvm: pblk: use right flag for GC allocation Javier González
2017-09-06 15:19 ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 4/6] lightnvm: pblk: free padded entries in write buffer Javier González
2017-09-06 15:22 ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 5/6] lightnvm: pblk: fix write I/O sync stat Javier González
2017-09-06 15:23 ` Johannes Thumshirn
2017-09-06 15:01 ` [PATCH 6/6] lightnvm: pblk: avoid deadlock on low LUN config Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=086e6df7-65d8-57b7-6605-d585985a3ddf@kernel.dk \
--to=axboe@kernel.dk \
--cc=jg@lightnvm.io \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matias@cnexlabs.com \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®