From: Lukasz Luba <lukasz.luba@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com,
will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk,
gregkh@linuxfoundation.org, rafael@kernel.org,
viresh.kumar@linaro.org, amitk@kernel.org,
daniel.lezcano@linaro.org, amit.kachhap@gmail.com,
bjorn.andersson@linaro.org, agross@kernel.org
Subject: Re: [PATCH 1/5] arch_topology: Introduce thermal pressure update function
Date: Fri, 15 Oct 2021 13:13:06 +0100 [thread overview]
Message-ID: <086e7186-7c41-5e39-4f6a-e1b44f63b867@arm.com> (raw)
In-Reply-To: <0ee4bc3b-0ad8-598d-417f-b8fe0a8fb8b1@linaro.org>
Hi Thara,
Thank you having a look at these patches.
My apologies for the delay, I haven't felt well
recently.
On 10/11/21 10:15 PM, Thara Gopinath wrote:
>
>
> On 10/7/21 4:07 AM, Lukasz Luba wrote:
[snip]
>> +/**
>> + * topology_thermal_pressure_update() - Update thermal pressure for CPUs
>> + * @cpus : The related CPUs which capacity has been reduced
>
> The related CPUs "for" which
thanks
>
>> + * @capped_freq : The maximum allowed frequency that CPUs can run at
[snip]
>> +
>> + capacity = capped_freq * max_capacity;
>> + capacity /= per_cpu(freq_factor, cpu);
>
> use mult_frac as used in other implementations ?
>
Good point. Let me check that. In that arch_topology file we never
use such trick, but in this case it makes sense IMO.
Regards,
Lukasz
next prev parent reply other threads:[~2021-10-15 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:07 [PATCH 0/5] Refactor thermal pressure update to avoid code duplication Lukasz Luba
2021-10-07 8:07 ` [PATCH 1/5] arch_topology: Introduce thermal pressure update function Lukasz Luba
2021-10-11 21:15 ` Thara Gopinath
2021-10-15 12:13 ` Lukasz Luba [this message]
2021-10-07 8:07 ` [PATCH 2/5] thermal: cpufreq_cooling: Use new " Lukasz Luba
2021-10-07 8:07 ` [PATCH 3/5] cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure Lukasz Luba
2021-10-11 21:17 ` Thara Gopinath
2021-10-15 12:13 ` Lukasz Luba
2021-10-07 8:07 ` [PATCH 4/5] cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function Lukasz Luba
2021-10-07 8:07 ` [PATCH 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=086e7186-7c41-5e39-4f6a-e1b44f63b867@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®